Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase fetch.min.bytes to 64kb for kafka buffer consumer #5378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Increase fetch.min.bytes to 64kb for kafka buffer consumer #5378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ntegrationTest/java/org/opensearch/dataprepper/plugins/kafka/buffer/ReadBufferHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ class ReadBufferHelper {
static Map.Entry<Collection<Record<Event>>, CheckpointState> awaitRead(final KafkaBuffer objectUnderTest) {
final Map.Entry<Collection<Record<Event>>, CheckpointState>[] lastReadResult = new Map.Entry[1];
await()
.atMost(Duration.ofSeconds(30))
.atMost(Duration.ofSeconds(45))
.until(() -> {
lastReadResult[0] = objectUnderTest.read(500);
lastReadResult[0] = objectUnderTest.read(2000);
return lastReadResult[0] != null && lastReadResult[0].getKey() != null && lastReadResult[0].getKey().size() >= 1;
});
return lastReadResult[0];
Expand Down
2 changes: 1 addition & 1 deletion ...gins/src/main/java/org/opensearch/dataprepper/plugins/kafka/buffer/BufferTopicConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class BufferTopicConfig extends CommonTopicConfig implements TopicProducerConfig
static final boolean DEFAULT_AUTO_COMMIT = false;
static final ByteCount DEFAULT_FETCH_MAX_BYTES = ByteCount.parse("50mb");
static final Duration DEFAULT_FETCH_MAX_WAIT = Duration.ofMillis(1000);
static final ByteCount DEFAULT_FETCH_MIN_BYTES = ByteCount.parse("2kb");
static final ByteCount DEFAULT_FETCH_MIN_BYTES = ByteCount.parse("64kb");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change for the source as well?

static final ByteCount DEFAULT_MAX_PARTITION_FETCH_BYTES = ByteCount.parse("1mb");
static final Duration DEFAULT_SESSION_TIMEOUT = Duration.ofSeconds(45);
static final String DEFAULT_AUTO_OFFSET_RESET = "earliest";
Expand Down
Loading