Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Austin and Henry as maintainer #1579

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Nov 1, 2023

Description

Nominate Austin and Henry as maintainer by following this process.

We already got approval from current maintainers.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env November 1, 2023 07:43 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env November 1, 2023 07:43 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env November 1, 2023 07:43 — with GitHub Actions Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot added documentation Improvements or additions to documentation infra labels Nov 1, 2023
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env November 1, 2023 07:43 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env November 1, 2023 07:43 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env November 1, 2023 07:43 — with GitHub Actions Inactive
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1579 (2c268dd) into main (012cc6c) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1579      +/-   ##
============================================
- Coverage     78.42%   78.41%   -0.02%     
+ Complexity     2382     2381       -1     
============================================
  Files           195      195              
  Lines          9595     9595              
  Branches        964      964              
============================================
- Hits           7525     7524       -1     
  Misses         1632     1632              
- Partials        438      439       +1     
Flag Coverage Δ
ml-commons 78.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@dhrubo-os
Copy link
Collaborator

Perhaps in the issue description, we can mention that the nomination followed the standard procedure of obtaining votes from existing maintainers.

I think we also need to update this: https://github.com/opensearch-project/ml-commons/blob/main/MAINTAINERS.md

@ylwu-amzn
Copy link
Collaborator Author

Perhaps in the issue description, we can mention that the nomination followed the standard procedure of obtaining votes from existing maintainers.

I think we also need to update this: https://github.com/opensearch-project/ml-commons/blob/main/MAINTAINERS.md

Yes, updated the description part, already updated MAINTAINERS.md in the PR

@ylwu-amzn ylwu-amzn merged commit e637a4a into opensearch-project:main Nov 1, 2023
14 of 18 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1579-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e637a4ab496f6ecc259d8246645fd467fb65969b
# Push it to GitHub
git push --set-upstream origin backport/backport-1579-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1579-to-2.x.

TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
rbhavna pushed a commit to rbhavna/ml-commons that referenced this pull request Nov 20, 2023
rbhavna pushed a commit to rbhavna/ml-commons that referenced this pull request Nov 20, 2023
rbhavna pushed a commit to rbhavna/ml-commons that referenced this pull request Nov 24, 2023
dhrubo-os pushed a commit that referenced this pull request Nov 27, 2023
* add triaging doc (#1250)

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix missing lombok version compilation failure issue (#1278)

* Fix missing lombok version compilation failure issue

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* Updated developer guide to include links for getting started with git (#1409)

Signed-off-by: Divit Rawal <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* add Austin and Henry as maintainer (#1579)

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* Apply spotless to ml-algorithms package (#1610)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: Divit Rawal <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Co-authored-by: zane-neo <[email protected]>
Co-authored-by: Divit Rawal <[email protected]>
Co-authored-by: Tyler Ohlsen <[email protected]>
dhrubo-os pushed a commit that referenced this pull request Nov 28, 2023
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
reta pushed a commit to reta/ml-commons that referenced this pull request Jan 12, 2024
* add triaging doc (opensearch-project#1250)

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix missing lombok version compilation failure issue (opensearch-project#1278)

* Fix missing lombok version compilation failure issue

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* Updated developer guide to include links for getting started with git (opensearch-project#1409)

Signed-off-by: Divit Rawal <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* add Austin and Henry as maintainer (opensearch-project#1579)

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* Apply spotless to ml-algorithms package (opensearch-project#1610)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>

* fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: Divit Rawal <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Co-authored-by: zane-neo <[email protected]>
Co-authored-by: Divit Rawal <[email protected]>
Co-authored-by: Tyler Ohlsen <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation infra
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

3 participants