-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for the RAG pipeline covering OpenAI and Bedrock #2213
Conversation
Signed-off-by: Austin Lee <[email protected]>
Signed-off-by: Austin Lee <[email protected]>
Signed-off-by: Austin Lee <[email protected]>
Signed-off-by: Austin Lee <[email protected]>
changes in memory API. Signed-off-by: Austin Lee <[email protected]>
@ylwu-amzn can you merge this? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2213-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d645c8369fa87cbd17ca23791d02cab487a7dbd0
# Push it to GitHub
git push --set-upstream origin backport/backport-2213-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.13 2.13
# Navigate to the new working tree
cd .worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-2213-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d645c8369fa87cbd17ca23791d02cab487a7dbd0
# Push it to GitHub
git push --set-upstream origin backport/backport-2213-to-2.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.13 Then, create a pull request where the |
backport PRs are failing. Could you please check? @austintlee |
#2235 @dhrubo-os does this look ok? The diff doesn't look right to me. |
|
oh it seems |
For 2.x, I get this message:
|
From this workflow log: https://github.com/opensearch-project/ml-commons/actions/runs/8348785119/job/22851492548 Looks like backport is failing for :
Did you take all the updates from the branch? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2213-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d645c8369fa87cbd17ca23791d02cab487a7dbd0
# Push it to GitHub
git push --set-upstream origin backport/backport-2213-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.13 2.13
# Navigate to the new working tree
cd .worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-2213-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d645c8369fa87cbd17ca23791d02cab487a7dbd0
# Push it to GitHub
git push --set-upstream origin backport/backport-2213-to-2.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.13 Then, create a pull request where the |
opensearch-project#2213) * Add integration tests for the RAG pipeline covering OpenAI and Bedrock. Signed-off-by: Austin Lee <[email protected]> * Use us-west-2 for testing. Signed-off-by: Austin Lee <[email protected]> * Fix spotless Signed-off-by: Austin Lee <[email protected]> * Fix broken import. Signed-off-by: Austin Lee <[email protected]> * Fix loading of default feature flag settings, update tests to pick up changes in memory API. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> --------- Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit d645c83)
opensearch-project#2213) * Add integration tests for the RAG pipeline covering OpenAI and Bedrock. Signed-off-by: Austin Lee <[email protected]> * Use us-west-2 for testing. Signed-off-by: Austin Lee <[email protected]> * Fix spotless Signed-off-by: Austin Lee <[email protected]> * Fix broken import. Signed-off-by: Austin Lee <[email protected]> * Fix loading of default feature flag settings, update tests to pick up changes in memory API. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> --------- Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit d645c83)
… OpenAI and Bedroc… (#2247) * Add integration tests for the RAG pipeline covering OpenAI and Bedrock (#2213) * Add integration tests for the RAG pipeline covering OpenAI and Bedrock. Signed-off-by: Austin Lee <[email protected]> * Use us-west-2 for testing. Signed-off-by: Austin Lee <[email protected]> * Fix spotless Signed-off-by: Austin Lee <[email protected]> * Fix broken import. Signed-off-by: Austin Lee <[email protected]> * Fix loading of default feature flag settings, update tests to pick up changes in memory API. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> --------- Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit d645c83) * Fix port to 2.13. Signed-off-by: Austin Lee <[email protected]> * Fix spotless. Signed-off-by: Austin Lee <[email protected]> --------- Signed-off-by: Austin Lee <[email protected]>
…OpenAI and Bedroc… (#2246) * Add integration tests for the RAG pipeline covering OpenAI and Bedrock (#2213) * Add integration tests for the RAG pipeline covering OpenAI and Bedrock. Signed-off-by: Austin Lee <[email protected]> * Use us-west-2 for testing. Signed-off-by: Austin Lee <[email protected]> * Fix spotless Signed-off-by: Austin Lee <[email protected]> * Fix broken import. Signed-off-by: Austin Lee <[email protected]> * Fix loading of default feature flag settings, update tests to pick up changes in memory API. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> * Remove unused code. Signed-off-by: Austin Lee <[email protected]> --------- Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit d645c83) * Fix port to 2.x. Signed-off-by: Austin Lee <[email protected]> --------- Signed-off-by: Austin Lee <[email protected]>
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.