Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request level parameters for system_prompt and user_instructions. #2236

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add request level parameters for system_prompt and user_instructions. #2236

merged 1 commit into from
Mar 20, 2024

Conversation

austintlee
Copy link
Collaborator

Description

Add request level parameters for system_prompt and user_instructions.

Issues Resolved

#2214

Check List

  • [ x] New functionality includes testing.
    • [x ] All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 19, 2024 22:33 — with GitHub Actions Failure
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 19, 2024 22:34 — with GitHub Actions Failure
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 19, 2024 23:23 — with GitHub Actions Failure
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 19, 2024 23:23 — with GitHub Actions Failure
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 19, 2024 23:30 — with GitHub Actions Failure
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 19, 2024 23:30 — with GitHub Actions Failure
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 20, 2024 00:19 — with GitHub Actions Failure
@austintlee
Copy link
Collaborator Author 

Tests with failures:
 - org.opensearch.ml.rest.SecureMLRestIT.testTrainModelWithFullAccessThenPredict
 - org.opensearch.ml.rest.SecureMLRestIT.testPredictWithReadOnlyMLAccess

Not related to my change.

@austintlee
Copy link
Collaborator Author

@dhrubo-os @ylwu-amzn Any chance this can get into 2.13?

@austintlee austintlee force-pushed the custom-prompts-main-2 branch from c193dbe to a066434 Compare March 20, 2024 17:09
@austintlee austintlee requested a review from xinyual as a code owner March 20, 2024 17:09
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 17:09 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 17:09 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 17:09 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 17:09 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 17:09 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 17:09 — with GitHub Actions Inactive
@austintlee austintlee had a problem deploying to ml-commons-cicd-env March 20, 2024 17:57 — with GitHub Actions Failure
@austintlee
Copy link
Collaborator Author

@dhrubo-os @HenryL27

@austintlee austintlee merged commit 80c9908 into opensearch-project:main Mar 20, 2024
13 of 16 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
@austintlee @github-actions
Add request level parameters for system_prompt and user_instructions. (…
9cbc61f 
…#2236)

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 80c9908)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
@austintlee @github-actions
Add request level parameters for system_prompt and user_instructions. (…
74fc11d 
…#2236)

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 80c9908)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2024
Merged
dhrubo-os pushed a commit that referenced this pull request Mar 20, 2024
@opensearch-trigger-bot @austintlee
Add request level parameters for system_prompt and user_instructions. (…
4dc590b 
…#2236) (#2250)

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 80c9908)

Co-authored-by: Austin Lee <[email protected]>
dhrubo-os pushed a commit that referenced this pull request Mar 20, 2024
@opensearch-trigger-bot @austintlee
Add request level parameters for system_prompt and user_instructions. (…
7578d70 
…#2236) (#2251)

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 80c9908)

Co-authored-by: Austin Lee <[email protected]>
@pyek-bot pyek-bot mentioned this pull request Oct 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@HenryL27 HenryL27 HenryL27 approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austintlee @dhrubo-os @HenryL27 @ylwu-amzn