Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query insights dashboards style integration group query details #70

Conversation

KishoreKicha14
Copy link
Contributor

@KishoreKicha14 KishoreKicha14 commented Jan 24, 2025

GroupQueryDetails

Description

This PR refines the UI components and routing structure for the Query Insights application, ensuring consistency with OpenSearch design standards and improving usability. Key changes include:

  • Ensures proper heading hierarchy (<h1>, <h2>, etc.) using EuiTitle and EuiText for accessibility and readability.
  • Replaces inline padding with reusable styles for consistent page layouts.
  • Implements compressed inputs, tabs, and smaller button styles (size="s") for a uniform and modern interface.

Developer Certificate of Origin

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on the Developer Certificate of Origin and signing off your commits, please check here.

@KishoreKicha14 KishoreKicha14 force-pushed the Fix-Query-Insights-Dashboards-Trineo-style-integration-GroupQueryDetails branch from c379c94 to f53f0ed Compare January 31, 2025 08:59
…ils-Tests&lint

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
@KishoreKicha14 KishoreKicha14 force-pushed the Fix-Query-Insights-Dashboards-Trineo-style-integration-GroupQueryDetails branch from f53f0ed to 963bbda Compare January 31, 2025 23:45
@ansjcy ansjcy changed the title Fix query insights dashboards trineo style integration group query details Fix query insights dashboards style integration group query details Jan 31, 2025
@ansjcy
Copy link
Member

ansjcy commented Feb 10, 2025

Could you update the screenshot in the PR to reflect the latest change?

Copy link
Member

@ansjcy ansjcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging this PR. Thanks @KishoreKicha14

@ansjcy ansjcy merged commit 69a60c5 into opensearch-project:main Feb 10, 2025
8 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 14, 2025
…ils-Tests&lint (#70)

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
(cherry picked from commit 69a60c5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 14, 2025
…ils-Tests&lint (#70)

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
(cherry picked from commit 69a60c5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Feb 14, 2025
…ils-Tests&lint (#70) (#107)

(cherry picked from commit 69a60c5)

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy pushed a commit that referenced this pull request Feb 14, 2025
…ils-Tests&lint (#70) (#109)

(cherry picked from commit 69a60c5)

Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants