-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query insights dashboards style integration group query details #70
Merged
ansjcy
merged 1 commit into
opensearch-project:main
from
KishoreKicha14:Fix-Query-Insights-Dashboards-Trineo-style-integration-GroupQueryDetails
Feb 10, 2025
Merged
Fix query insights dashboards style integration group query details #70
ansjcy
merged 1 commit into
opensearch-project:main
from
KishoreKicha14:Fix-Query-Insights-Dashboards-Trineo-style-integration-GroupQueryDetails
Feb 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c379c94
to
f53f0ed
Compare
…ils-Tests&lint Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
f53f0ed
to
963bbda
Compare
Could you update the screenshot in the PR to reflect the latest change? |
ansjcy
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging this PR. Thanks @KishoreKicha14
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
…ils-Tests&lint (#70) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 69a60c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
…ils-Tests&lint (#70) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Co-authored-by: Kishore Kumaar Natarajan <[email protected]> (cherry picked from commit 69a60c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Feb 14, 2025
…ils-Tests&lint (#70) (#107) (cherry picked from commit 69a60c5) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy
pushed a commit
that referenced
this pull request
Feb 14, 2025
…ils-Tests&lint (#70) (#109) (cherry picked from commit 69a60c5) Signed-off-by: Kishore Kumaar Natarajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kishore Kumaar Natarajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the UI components and routing structure for the Query Insights application, ensuring consistency with OpenSearch design standards and improving usability. Key changes include:
<h1>
,<h2>
, etc.) usingEuiTitle
andEuiText
for accessibility and readability.size="s"
) for a uniform and modern interface.Developer Certificate of Origin
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on the Developer Certificate of Origin and signing off your commits, please check here.