Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query insights dashboards style integration group query details #70

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix query insights dashboards style integration group query details #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions public/pages/QueryGroupDetails/Components/QueryGroupAggregateSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@
*/

import React from 'react';
import { EuiFlexGrid, EuiFlexItem, EuiHorizontalRule, EuiPanel, EuiText } from '@elastic/eui';
import {
EuiFlexGrid,
EuiFlexItem,
EuiHorizontalRule,
EuiPanel,
EuiTitle,
EuiDescriptionList,
} from '@elastic/eui';
import {
AVERAGE_CPU_TIME,
AVERAGE_LATENCY,
Expand All @@ -17,28 +24,37 @@ import { calculateMetric } from '../../../../common/utils/MetricUtils';
// Panel component for displaying query group detail values
const PanelItem = ({ label, value }: { label: string; value: string | number }) => (
<EuiFlexItem>
<EuiText size="xs">
<h4>{label}</h4>
</EuiText>
<EuiText size="xs">{value}</EuiText>
<EuiDescriptionList
compressed={true}
listItems={[
{
title: <h4>{label}</h4>,
description: value,
},
]}
/>
</EuiFlexItem>
);

export const QueryGroupAggregateSummary = ({ query }: { query: any }) => {
if (!query) {
return <EuiText size="s">No query data available.</EuiText>;
return (
<EuiTitle size="s">
<h2>No query data available.</h2>
</EuiTitle>
);
}
const { measurements, id: id, group_by: groupBy } = query;
const queryCount =
measurements.latency?.count || measurements.cpu?.count || measurements.memory?.count || 1;
return (
<EuiPanel>
<EuiText size="xs">
<EuiTitle size="s">
<h2>
Aggregate summary for {queryCount} {queryCount === 1 ? 'query' : 'queries'}
</h2>
</EuiText>
<EuiHorizontalRule margin="m" />
</EuiTitle>
<EuiHorizontalRule margin="xs" />
<EuiFlexGrid columns={4}>
<PanelItem label={ID} value={id} />
<PanelItem
Expand Down
34 changes: 25 additions & 9 deletions public/pages/QueryGroupDetails/Components/QueryGroupSampleQuerySummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@
*/

import React from 'react';
import { EuiFlexGrid, EuiFlexItem, EuiHorizontalRule, EuiPanel, EuiText } from '@elastic/eui';
import {
EuiFlexGrid,
EuiFlexItem,
EuiHorizontalRule,
EuiPanel,
EuiTitle,
EuiDescriptionList,
} from '@elastic/eui';
import {
INDICES,
NODE_ID,
Expand All @@ -15,16 +22,25 @@ import {

const PanelItem = ({ label, value }: { label: string; value: string | number }) => (
<EuiFlexItem>
<EuiText size="xs">
<h4>{label}</h4>
</EuiText>
<EuiText size="xs">{value}</EuiText>
<EuiDescriptionList
compressed={true}
listItems={[
{
title: <h4>{label}</h4>,
description: value,
},
]}
/>
</EuiFlexItem>
);

export const QueryGroupSampleQuerySummary = ({ query }: { query: any }) => {
if (!query) {
return <EuiText size="s">No query data available.</EuiText>;
return (
<EuiTitle size="s">
<h2>No query data available.</h2>
</EuiTitle>
);
}
const convertTime = (unixTime: number) => {
const date = new Date(unixTime);
Expand All @@ -41,10 +57,10 @@ export const QueryGroupSampleQuerySummary = ({ query }: { query: any }) => {
} = query;
return (
<EuiPanel>
<EuiText size="xs">
<EuiTitle size="s">
<h2>Sample query summary</h2>
</EuiText>
<EuiHorizontalRule margin="m" />
</EuiTitle>
<EuiHorizontalRule margin="xs" />
<EuiFlexGrid columns={4}>
<PanelItem label={TIMESTAMP} value={convertTime(timestamp)} />
<PanelItem label={INDICES} value={indices.toString()} />
Expand Down
12 changes: 6 additions & 6 deletions public/pages/QueryGroupDetails/QueryGroupDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
EuiHorizontalRule,
EuiPanel,
EuiSpacer,
EuiText,
EuiTitle,
EuiIconTip,
} from '@elastic/eui';
Expand Down Expand Up @@ -193,12 +192,13 @@ export const QueryGroupDetails = ({
<EuiPanel>
<EuiFlexGroup alignItems="center" justifyContent="spaceBetween">
<EuiFlexItem>
<EuiText size="xs">
<EuiTitle size="xs">
<h2>Query</h2>
</EuiText>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButton
size="s"
iconSide="right"
iconType="popout"
target="_blank"
Expand All @@ -223,10 +223,10 @@ export const QueryGroupDetails = ({
</EuiFlexItem>
<EuiFlexItem grow={1} style={{ alignSelf: 'start' }}>
<EuiPanel>
<EuiText size="xs">
<EuiTitle size="s">
<h2>Latency</h2>
</EuiText>
<EuiHorizontalRule margin="m" />
</EuiTitle>
<EuiHorizontalRule margin="xs" />
<div id="latency" />
</EuiPanel>
</EuiFlexItem>
Expand Down
Loading
Loading