Model changes for query_group_hashcode and id #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshsidd
force-pushed
the
sid/model-changes
branch
3 times, most recently
from
6830b52 to
2fa7e5b
Compare
ansjcy
approved these changes
Jan 16, 2025
src/main/java/org/opensearch/plugin/insights/rules/model/SearchQueryRecord.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
force-pushed
the
sid/model-changes
branch
from
2fa7e5b to
effbdea
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 1d991b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Jan 16, 2025
(cherry picked from commit 1d991b8) Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Model changes for
query_group_hashcodeandid.query_group_hashcode: Will be used to store the hashcode of the query shape and used by the group_by feature (only applicable for query groups)
id: UUID used to uniquely identify a query/group. This will be displayed in the id column on the dashboard
Updated the unit tests.
Changes are part of the larger set of changes required to solve the issue where the query/group details page on the dashboard is broken when refreshed.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Addresses: #159
Addresses: opensearch-project/query-insights-dashboards#12
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Sample Dashboard Screenshots with UUID:
