schedconf: consume deployer updates #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ffromani
force-pushed
the
sched-render-config-unstruct
branch
from
c65e341 to
a4f7c57
Compare
ffromani
force-pushed
the
sched-render-config-unstruct
branch
from
a4f7c57 to
b5de7b4
Compare
ffromani
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ffromani
force-pushed
the
sched-render-config-unstruct
branch
from
b5de7b4 to
70e81e6
Compare
This was referenced Oct 27, 2023
ffromani
force-pushed
the
sched-render-config-unstruct
branch
from
70e81e6 to
0125ae8
Compare
shajmakh
reviewed
Oct 31, 2023
port to the new APIs. Reduce significantly the dependencies footprint. Signed-off-by: Francesco Romani <[email protected]>
also update transitive dependencies Signed-off-by: Francesco Romani <[email protected]>
new dep pulled by ginkgo Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
sched-render-config-unstruct
branch
from
7e5e42a to
1034cdb
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cherry-pick release-4.14 |
|
@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ffromani: #734 failed to apply on top of branch "release-4.14": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ffromani
added
the
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consume deployer update to mutate scheduler config using
unstructured, which significantly lowers the dependencies footprint. This also enables us to pull the latest kubernetes dependencies.Although there is no expected change of behavior, this change is significant in deployer code and needs proper testing.