k8s: taints: import package #746
Conversation
to remove the last dependency from k8s.io/kubernetes, we import (soft-fork) the taints package, and we fix our imports to use the bundled version. Signed-off-by: Francesco Romani <[email protected]>
remove now-unnecessary deps Signed-off-by: Francesco Romani <[email protected]>
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.14 |
|
@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test security |
|
@ffromani: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
thanks for the PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ffromani: new pull request created: #754 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ffromani
added
the
cherry-pick-approved
import the taints package, used just once in the e2e serial suite, to remove the last dependency from k8s.io/kubernetes
this PR won't actually remove that dep, but other PRs in the pipeline will.
no intended changes in behavior