OCPBUGS-38975: monitor should not exit for temp api disconnect

[rwsu]

This commit updates the isMonitoringDone function to retry and not exit if the error from reading the node-joiner pod is

Get "https://api.ostest.test.metalkube.org:6443/api/v1/namespaces/openshift-node-joiner-zfbp9/pods/node-joiner-monitor-4lx8l": EOF

This happens if the oc client is temporarily disconnected from the api server. The error returned is type net/url/Error.

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-38975, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit updates the isMonitoringDone function to retry and not exit if the error from reading the node-joiner pod is

Get "https://api.ostest.test.metalkube.org:6443/api/v1/namespaces/openshift-node-joiner-zfbp9/pods/node-joiner-monitor-4lx8l": EOF

This happens if the oc client is temporarily disconnected from the api server. The error returned is type net/url/Error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rwsu]

/jira refresh

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-38975, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rwsu]

/retest-required

[rwsu]

/test e2e-agnostic-ovn-cmd

[rwsu]

/test e2e-agnostic-ovn-cmd

[openshift-ci]

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[andfasano]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cli/admin/nodeimage/OWNERS [andfasano,rwsu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rwsu]

This change only affects the "oc adm node-image" command. It fixes an issue that we see quite often in CI and testing, so we'd like to have it merged.

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@rwsu: Jira Issue OCPBUGS-38975: All pull requests linked via external trackers have merged:

• openshift/oc#1949

Jira Issue OCPBUGS-38975 has been moved to the MODIFIED state.

In response to this:

This commit updates the isMonitoringDone function to retry and not exit if the error from reading the node-joiner pod is

Get "https://api.ostest.test.metalkube.org:6443/api/v1/namespaces/openshift-node-joiner-zfbp9/pods/node-joiner-monitor-4lx8l": EOF

This happens if the oc client is temporarily disconnected from the api server. The error returned is type net/url/Error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rwsu]

/jira backport release-4.18 release-4.17

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli
This PR has been included in build openshift-enterprise-cli-container-v4.19.0-202501141108.p0.ge005223.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-tools
This PR has been included in build ose-tools-container-v4.19.0-202501141108.p0.ge005223.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer
This PR has been included in build openshift-enterprise-deployer-container-v4.19.0-202501141108.p0.ge005223.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts
This PR has been included in build ose-cli-artifacts-container-v4.19.0-202501141108.p0.ge005223.assembly.stream.el9.
All builds following this will include this PR.

[rwsu]

/jira backport release-4.18 release-4.17

[rwsu]

/jira backport release-4.18

[openshift-ci-robot]

@rwsu: The following backport issues have been created:

• OCPBUGS-48714 for branch release-4.18

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: new pull request created: #1963

In response to this:

@rwsu: The following backport issues have been created:

• OCPBUGS-48714 for branch release-4.18

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.