Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-38975: monitor should not exit for temp api disconnect #1949

Merged
merged 1 commit into from
Jan 14, 2025
Merged

OCPBUGS-38975: monitor should not exit for temp api disconnect #1949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/cli/admin/nodeimage/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ package nodeimage

import (
"context"
"errors"
"fmt"
"net"
"net/url"
"strings"
"time"

Expand Down Expand Up @@ -220,6 +222,11 @@ func (o *MonitorOptions) isMonitoringDone(ctx context.Context) (bool, error) {
if retry.IsHTTPClientError(err) {
return false, nil
}
// api server may become temporarily unavailable, return false to retry
var urlErr *url.Error
if errors.As(err, &urlErr) {
return false, nil
}
klog.V(2).Infof("pod should exist but is not found: %v", err)
return false, err
}
Expand Down