extensions: adapt for new rpm-ostree support #496
Conversation
|
Needs coreos/coreos-assembler#2028. |
openshift-ci-robot
added
the
approved
jlebon
force-pushed
the
pr/extensions-tweak
branch
from
255026c to
3ad6ec3
Compare
|
Let's just hold this until the /hold |
openshift-ci-robot
added
the
do-not-merge/hold
jlebon
force-pushed
the
pr/extensions-tweak
branch
from
3ad6ec3 to
192494f
Compare
|
cosa PR is merged now! /retest |
openshift-ci-robot
removed
the
do-not-merge/hold
|
One suggestion, but otherwise LGTM! /approve |
With coreos/rpm-ostree#2439 and coreos/coreos-assembler#2028, support for extensions is now more robust. The extensions.yaml file is now fed directly to rpm-ostree. We just need to do some minor tweaks: - drop listing usbguard deps, rpm-ostree fetches them automatically - split the devel bits into two extensions: one is an OS extension which contains the devel and headers packages, and the other is a development extension containing kernel packages already in the base (marking it as a development extension will signal the MCO that it's not intended to be directly layered on the host) - use `match-base-evr: kernel` on those to enforce that the kernel development packages have the same EVR as the base kernel package in the OSTree The `cosa upload-oscontainer` command now also supports `oscontainer.yaml` specifying "important" packages whose EVRA are included directly as a label on the resulting image.
jlebon
force-pushed
the
pr/extensions-tweak
branch
from
192494f to
76f510c
Compare
|
/retest |
|
I think @cgwalters was chasing this down as part of |
|
So... since CI is broken but doesn't cover this anyway, and this is blocking pipelines, let's just get this in? Then we get to actual regressions in this new path sooner and can fix them sooner too. :) |
|
Yeah, that's fine by me. |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Now just needs a |
|
/lgtm For xref purposes, CI failures tracking in #506 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With coreos/rpm-ostree#2439 and
coreos/coreos-assembler#2028, support for
extensions is now more robust.
The extensions.yaml file is now fed directly to rpm-ostree. We just need
to do some minor tweaks:
contains the devel and headers packages, and the other is a
development extension containing kernel packages already in the base
(marking it as a development extension will signal the MCO that it's
not intended to be directly layered on the host)
match-base-evr: kernelon those to enforce that the kerneldevelopment packages have the same EVR as the base kernel package in
the OSTree