Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24700: update stackrox CI image #55687

Merged

Conversation

BradLugo
Copy link
Contributor

@BradLugo BradLugo commented Aug 16, 2024

Description

Updates the StackRox CI images used for testing in OSCI to stackrox-ui-test-0.4.2 to resolve the CentOS 8 package mirror deprecation.

Please see stackrox/rox-ci-image#212 for more details.

/uncc
/hold

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2024

@BradLugo: This pull request references ROX-24700 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Description

todo

/uncc
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 16, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@BradLugo BradLugo force-pushed the blugo/ROX-24700-update-ci-image branch 4 times, most recently from e9a78b7 to abcf55c Compare August 19, 2024 18:47
@BradLugo
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BradLugo BradLugo force-pushed the blugo/ROX-24700-update-ci-image branch 2 times, most recently from f013c7f to 93b91a1 Compare August 21, 2024 20:12
@BradLugo
Copy link
Contributor Author

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BradLugo
Copy link
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests pull-ci-stackrox-stackrox-master-gke-ui-e2e-tests pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-ui-e2e-tests pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-qa-e2e-tests pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-nongroovy-e2e-tests pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-ebpf-qa-e2e-tests pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-compliance-e2e-tests

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@BradLugo: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@BradLugo
Copy link
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests pull-ci-stackrox-stackrox-master-gke-ui-e2e-tests

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BradLugo
Copy link
Contributor Author

/retest

@BradLugo
Copy link
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-release-x.y-gke-qa-e2e-tests pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests pull-ci-stackrox-stackrox-release-x.y-aro-qa-e2e-tests pull-ci-stackrox-stackrox-release-x.y-eks-ebpf-qa-e2e-tests pull-ci-stackrox-stackrox-release-x.y-eks-qa-e2e-tests pull-ci-stackrox-stackrox-release-x.y-gke-race-condition-qa-e2e-tests pull-ci-stackrox-stackrox-release-x.y-gke-ui-e2e-tests

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BradLugo
Copy link
Contributor Author

I spot-checked some of the failed jobs and they mostly error due to known flakes

@BradLugo
Copy link
Contributor Author

/pj-rehearse ack
/unhold
/cc @tommartensen @davdhacs @msugakov

@openshift-ci-robot
Copy link
Contributor

@BradLugo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 22, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2024

@BradLugo: This pull request references ROX-24700 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Updates the StackRox CI images used for testing in OSCI to stackrox-ui-test-0.4.2 to resolve the CentOS 8 package mirror deprecation.

Please see stackrox/rox-ci-image#212 for more details.

/uncc
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@@ -23,7 +23,7 @@ build_root:
image_stream_tag:
name: apollo-ci
namespace: stackrox
tag: stackrox-test-0.3.57.1
tag: stackrox-ui-test-0.4.2.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with reverting this or any other release branch

Copy link
Contributor

@davdhacs davdhacs Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0.4.2.1 for these but 0.4.2 for the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. My regex didn't capture to the end

Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -23,7 +23,7 @@ build_root:
image_stream_tag:
name: apollo-ci
namespace: stackrox
tag: stackrox-test-0.3.57.1
tag: stackrox-ui-test-0.4.2.1
Copy link
Contributor

@davdhacs davdhacs Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0.4.2.1 for these but 0.4.2 for the others?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@davdhacs
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BradLugo, davdhacs Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

This appears to either be a bug or the process changed (a new step in the process that will gate our changes).

@davdhacs
Copy link
Contributor

This appears to either be a bug or the process changed (a new step in the process that will gate our changes).

@smg247 pointed out it is because of modifying the repo config check, https://github.com/openshift/release/blob/93b91a13eb5721be274e4dd1edc97f1dfd6d8b3e/ci-operator/config/openshift/release/openshift-release-master__stackrox-stackrox.yaml. I missed that that file was in here.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 22, 2024
@davdhacs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 22, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@BradLugo
Copy link
Contributor Author

/retest

@BradLugo BradLugo force-pushed the blugo/ROX-24700-update-ci-image branch from 55398d1 to 8d477c5 Compare August 22, 2024 23:04
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@BradLugo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-stackrox-master-ocp-dev-preview-compliance-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-ebpf-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-fips-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-nongroovy-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-operator-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-scanner-v4-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-sensor-integration-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-compliance-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-ebpf-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-operator-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-scanner-v4-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-sensor-integration-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-4.4-ocp-4-11-ui-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-3.74-ocp-4-14-operator-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-release-3.74-ocp-4-14-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-compliance-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-crun-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-ebpf-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-fips-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-nongroovy-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-operator-e2e-tests stackrox/stackrox presubmit Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-16-qa-e2e-tests stackrox/stackrox presubmit Ci-operator config changed

A total of 201 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@BradLugo
Copy link
Contributor Author

/retest

@davdhacs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
Copy link
Contributor

openshift-ci bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradLugo, davdhacs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davdhacs
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 23, 2024
Copy link
Contributor

openshift-ci bot commented Aug 23, 2024

@BradLugo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stackrox/stackrox/release-x.y/ocp-4-16-operator-e2e-tests abcf55c link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-ocp-4-16-operator-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/ocp-4-16-fips-qa-e2e-tests abcf55c link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-ocp-4-16-fips-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/ocp-4-16-nongroovy-e2e-tests abcf55c link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-ocp-4-16-nongroovy-e2e-tests
ci/rehearse/stackrox/stackrox/release-4.5/ocp-4-16-nongroovy-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-nongroovy-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/ocp-4-12-ebpf-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-ebpf-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/gke-version-compatibility-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-gke-version-compatibility-tests
ci/rehearse/stackrox/stackrox/release-3.74/ocp-4-6-operator-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-3.74-ocp-4-6-operator-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/ocp-4-12-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-ocp-4-12-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-4.5/ocp-4-16-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-4.5/ocp-4-16-compliance-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-compliance-e2e-tests
ci/rehearse/stackrox/stackrox/release-3.74/ocp-4-6-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-3.74-ocp-4-6-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-4.5/ocp-4-16-ui-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-ui-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/ocp-4-16-ebpf-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-ocp-4-16-ebpf-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-4.5/ocp-4-16-ebpf-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-4.5-ocp-4-16-ebpf-qa-e2e-tests
ci/prow/build-clusters 8d477c5 link false /test build-clusters
ci/rehearse/stackrox/stackrox/release-x.y/aro-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-aro-qa-e2e-tests
ci/rehearse/stackrox/stackrox/release-x.y/gke-race-condition-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-release-x.y-gke-race-condition-qa-e2e-tests
ci/rehearse/stackrox/stackrox/master/gke-qa-e2e-tests 93b91a1 link unknown /pj-rehearse pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 71202d5 into openshift:master Aug 23, 2024
15 of 16 checks passed
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
* ROX-24700: update stackrox CI image

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants