#89 [REQUEST] Add fields for facilitator and editor to the story archetype #93
Conversation
…html" partial for templated with conditional rendering Finally calling "credits" template in "single.html"
…html" partial for templated with conditional rendering Finally calling "credits" template in "single.html"
There was a problem hiding this comment.
This should be "Claire Moss", not "Clarie Moss".
There was a problem hiding this comment.
Could we add a period at the end of the sentence?
There was a problem hiding this comment.
Just for cleanliness of the code, could you only add in line 48?
There was a problem hiding this comment.
Sure, would make the necessary changes
There was a problem hiding this comment.
I'm sorry, I think I communicated that poorly! Your approach of creating a new partial was great. Let's stick with that.
I was referencing the fact that it seems like you modified the indentation for lines that you didn't change, so the diff reflected changes on lines without material changes. No worries though, if you can just add back the partial, we can resolve formatting later.
There was a problem hiding this comment.
Created a new partial and calling it in single.html
added .vs in gitignore to remove .vs dir corrected Clarie Moss in thea-flowers.md
Finally removed .vs folder by removing cache and stashing all files based on new git ignore
There was a problem hiding this comment.
I'm sorry, I think I communicated that poorly! Your approach of creating a new partial was great. Let's stick with that.
I was referencing the fact that it seems like you modified the indentation for lines that you didn't change, so the diff reflected changes on lines without material changes. No worries though, if you can just add back the partial, we can resolve formatting later.
✅ Deploy Preview for opensourcestories ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Solution Description:
Added "editor" property in stories.md archetype and created "credits.html" partial for templated with conditional rendering
Finally calling "credits" template in "single.html"
SS of final result