Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#89 [REQUEST] Add fields for facilitator and editor to the story archetype #93

Merged
merged 9 commits into from
Jun 12, 2023
Merged

#89 [REQUEST] Add fields for facilitator and editor to the story archetype #93

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
58aee3e
Added "editor" property in stories.md archetype and created "credits.…
LuvvAggarwal Jun 9, 2023
50eaba4
Added "editor" property in stories.md archetype and created "credits.…
LuvvAggarwal Jun 9, 2023
d889a39
Added credits logic in single.html
LuvvAggarwal Jun 10, 2023
8b3548e
removing .vs folder
LuvvAggarwal Jun 10, 2023
d21fb3f
Remove .vs folder
LuvvAggarwal Jun 10, 2023
5e149ec
Remove .vs folder
LuvvAggarwal Jun 10, 2023
e434b5d
Removed .vs folder
LuvvAggarwal Jun 10, 2023
490c23b
Added period in the end of sentence
LuvvAggarwal Jun 10, 2023
7023931
Created credits.html partial
LuvvAggarwal Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
LuvvAggarwal marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ public/
.hugo_build.lock

# VSCode files
.vs/
.vscode/
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
!.vscode/*.code-snippets
.history/
*.vsix
*.vsix
1 change: 1 addition & 0 deletions archetypes/stories.md
View file
Open in desktop
juliaferraioli marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ bio:
storycorps: "https://archive.storycorps.org/embed/"
story_image: "images/storytellers/"
facilitators: [""]
editors: [""]
audio: "https://media.blubrry.com/1466155/content.blubrry.com/1466155/"
explicit: "no"
bytes:
Expand Down
1 change: 1 addition & 0 deletions content/stories/2023/thea-flowers.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Claire Moss", not "Clarie Moss".

Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ bio: "Thea Flowers is an open source advocate, music technologist, and weasel en
storycorps: "https://archive.storycorps.org/embed/3775783"
story_image: "images/misc/raspberry-pi.jpg"
facilitators: ["julia ferraioli"]
editors: ["Clarie Moss"]
audio: "https://media.blubrry.com/1466155/content.blubrry.com/1466155/Thea_Flowers_on_Open_Source_Hardware.mp3"
explicit: "no"
bytes: 23148789
Expand Down
30 changes: 20 additions & 10 deletions layouts/stories/single.html
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for cleanliness of the code, could you only add in line 48?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, would make the necessary changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I think I communicated that poorly! Your approach of creating a new partial was great. Let's stick with that.

I was referencing the fact that it seems like you modified the indentation for lines that you didn't change, so the diff reflected changes on lines without material changes. No worries though, if you can just add back the partial, we can resolve formatting later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new partial and calling it in single.html

Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,26 @@ <h1 class="f1 mt3 mb1">
</div>
</section>
<div class="nested-copy-line-height lh-copy {{ $.Param "post_content_classes" | default "avenir"}} f4 nested-links {{ $.Param "text_color" | default "almost-black" }} {{ cond (eq $.Site.Language.LanguageDirection "rtl") "pl4-l" "pr4-l" }} w-two-thirds-l">
{{- .Content -}}
{{- partial "tags.html" . -}}
<div class="mt6 instapaper_ignoref">
{{ if .Site.DisqusShortname }}
{{ template "_internal/disqus.html" . }}
{{ end }}
{{ if .Site.Params.commentoEnable }}
{{- partial "commento.html" . -}}
{{ end }}
</div>
{{- .Content -}}
<!--Credits-->
<p class="mt4 mb4 f6 pv2 dib black sans-serif">
The story was facilated by {{delimit .Params.facilitators ", " " and "}}
{{ if .Params.editors }}
<span>
and edited by {{delimit .Params.editors ", " " and "}}.
</span>
{{ end }}

</p>
{{- partial "tags.html" . -}}
<div class="mt6 instapaper_ignoref">
{{ if .Site.DisqusShortname }}
{{ template "_internal/disqus.html" . }}
{{ end }}
{{ if .Site.Params.commentoEnable }}
{{- partial "commento.html" . -}}
{{ end }}
</div>
</div>

<aside class="w-30-l mt6-l">
Expand Down