Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE] add support of shift operations #29057

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[PT FE] add support of shift operations #29057

wants to merge 4 commits into from
+148 −0

Conversation

Mohamed-Ashraf273
Copy link

Details:

  • added aten::lshift and aten::rshift
  • added aten::bitwise_left_shift and aten::bitwise_right_shift

Tickets:

@mvafin

@Mohamed-Ashraf273 Mohamed-Ashraf273 requested a review from a team as a code owner February 18, 2025 18:14
@Mohamed-Ashraf273 Mohamed-Ashraf273 mentioned this pull request Feb 18, 2025
Closed
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Feb 18, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Feb 18, 2025
@Mohamed-Ashraf273
Copy link
Author

hi @mvafin ,
I created this new PR because the old one had many unnecessary commits. It is ready for review.

mvafin
mvafin reviewed Feb 20, 2025
View reviewed changes
src/frontends/pytorch/src/op/bitwise.cpp
@@ -7,6 +7,8 @@
#include "openvino/op/bitwise_not.hpp"
#include "openvino/op/bitwise_or.hpp"
#include "openvino/op/bitwise_xor.hpp"
#include "openvino/op/bitwise_left_shift.hpp"
#include "openvino/op/bitwise_right_shift.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix code style, sort includes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvafin
thanks for your review, I've sorted them.

@Mohamed-Ashraf273
Copy link
Author

Hi @mvafin
I've fixed all code style issues, it is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin left review comments

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mohamed-Ashraf273 @mvafin @sys-openvino-ci