-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary copies in the Rust interface #41
Conversation
Signed-off-by: Marc Schoolderman <[email protected]>
Signed-off-by: Marc Schoolderman <[email protected]>
2f97ae1
to
35dda2b
Compare
Signed-off-by: Marc Schoolderman <[email protected]>
35dda2b
to
9437918
Compare
Signed-off-by: Marc Schoolderman <[email protected]>
Signed-off-by: Marc Schoolderman <[email protected]>
Signed-off-by: Marc Schoolderman <[email protected]>
b1e6147
to
48f483c
Compare
Signed-off-by: Marc Schoolderman <[email protected]>
2d53d75
to
65af32e
Compare
Signed-off-by: Marc Schoolderman <[email protected]>
65af32e
to
4762cb1
Compare
Note: since this PR touches a lot of things, the individual commits separate out the various changes in a better way. In hindsight, it would have been better to use ranges + objects instead of Rust slices. These mentioned changes are in PR #44 which can be merged into this one. |
Signed-off-by: Marc Schoolderman <[email protected]>
78547df
to
f4cfbd8
Compare
Signed-off-by: Marc Schoolderman <[email protected]>
c1df0b5
to
ea89f60
Compare
At some point, the data that was received was copied; either when receiving or when unpacking a nested message.
In this latter point (since encryption/decryption can happen in-place), that was unfortunate. But even in other scenarios not needlessly duplicating the payload data (which after all might be large) is a good idea.