Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 restrict datapages to only charts with vars that have any description* set #2920

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Nov 12, 2023

During the bug bash for data pages we realized that just checking for single indicator charts with schemaVersion == 2 was a bit too lenient. The reason for this was that some datasets were converted to using Origin instead of Source which is enough to bump the schemaVersion, but no human had actually looked at these indicators.

This PR changes the criterium now so that single indicator charts are shown as data pages if the indicator is schemaVersion == 2 and at least one of the following fields is set:

  • descriptionShort
  • descriptionFromProducer
  • descriptionKey
  • descriptionProcessing
  • presentation.titlePublic

@danyx23 danyx23 changed the base branch from feat-sources-modal to sources-bug-fixes November 16, 2023 17:01
@danyx23 danyx23 force-pushed the data-pages-only-vars-with-description branch from 1ca6ece to 8b0e027 Compare November 16, 2023 17:01
@danyx23 danyx23 mentioned this pull request Nov 16, 2023
@danyx23 danyx23 force-pushed the data-pages-only-vars-with-description branch from 8b0e027 to 512b75e Compare November 17, 2023 15:54
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch from 512b75e to 09da199 Compare November 23, 2023 10:48
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch from 09da199 to 6cf9f9a Compare November 23, 2023 16:19
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch from 6cf9f9a to bb5e3db Compare November 24, 2023 08:49
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch 2 times, most recently from 781cb35 to 0ffaf9e Compare November 24, 2023 10:44
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch from 0ffaf9e to fc9a200 Compare November 24, 2023 12:02
@danyx23 danyx23 force-pushed the data-pages-only-vars-with-description branch from fc9a200 to 58c2391 Compare November 24, 2023 16:50
@danyx23 danyx23 marked this pull request as ready for review November 24, 2023 17:43
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch from 58c2391 to c7e1716 Compare November 24, 2023 19:58
@sophiamersmann sophiamersmann force-pushed the data-pages-only-vars-with-description branch from c7e1716 to 29ede79 Compare November 24, 2023 20:03
Copy link
Contributor Author

danyx23 commented Nov 27, 2023

Merge activity

  • Nov 27, 6:24 AM: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Nov 27, 6:28 AM: @danyx23 merged this pull request with Graphite.

Base automatically changed from sources-bug-fixes to master November 27, 2023 11:28
@danyx23 danyx23 merged commit 395442a into master Nov 27, 2023
10 checks passed
@danyx23 danyx23 deleted the data-pages-only-vars-with-description branch November 27, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant