-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 restrict datapages to only charts with vars that have any description* set #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2023
Merged
This was referenced Nov 12, 2023
sophiamersmann
force-pushed
the
feat-sources-modal
branch
from
November 16, 2023 16:05
f109777
to
289d052
Compare
danyx23
force-pushed
the
feat-sources-modal
branch
from
November 16, 2023 17:01
289d052
to
8f8bae5
Compare
danyx23
changed the base branch from
feat-sources-modal
to
sources-bug-fixes
November 16, 2023 17:01
danyx23
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 16, 2023 17:01
1ca6ece
to
8b0e027
Compare
Merged
danyx23
force-pushed
the
sources-bug-fixes
branch
from
November 17, 2023 15:54
21c3d9a
to
f137ad8
Compare
danyx23
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 17, 2023 15:54
8b0e027
to
512b75e
Compare
This was referenced Nov 17, 2023
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 23, 2023 10:48
512b75e
to
09da199
Compare
sophiamersmann
force-pushed
the
sources-bug-fixes
branch
from
November 23, 2023 16:19
3a1d026
to
35061fe
Compare
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 23, 2023 16:19
09da199
to
6cf9f9a
Compare
sophiamersmann
force-pushed
the
sources-bug-fixes
branch
from
November 24, 2023 08:49
35061fe
to
0b8efaf
Compare
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 24, 2023 08:49
6cf9f9a
to
bb5e3db
Compare
sophiamersmann
force-pushed
the
sources-bug-fixes
branch
from
November 24, 2023 09:07
0b8efaf
to
8fc3965
Compare
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
2 times, most recently
from
November 24, 2023 10:44
781cb35
to
0ffaf9e
Compare
sophiamersmann
force-pushed
the
sources-bug-fixes
branch
from
November 24, 2023 12:02
78ba1bb
to
8b10c8c
Compare
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 24, 2023 12:02
0ffaf9e
to
fc9a200
Compare
danyx23
force-pushed
the
sources-bug-fixes
branch
from
November 24, 2023 16:50
8b10c8c
to
b4db9ef
Compare
danyx23
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 24, 2023 16:50
fc9a200
to
58c2391
Compare
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 24, 2023 19:58
58c2391
to
c7e1716
Compare
sophiamersmann
force-pushed
the
data-pages-only-vars-with-description
branch
from
November 24, 2023 20:03
c7e1716
to
29ede79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the bug bash for data pages we realized that just checking for single indicator charts with schemaVersion == 2 was a bit too lenient. The reason for this was that some datasets were converted to using Origin instead of Source which is enough to bump the schemaVersion, but no human had actually looked at these indicators.
This PR changes the criterium now so that single indicator charts are shown as data pages if the indicator is schemaVersion == 2 and at least one of the following fields is set: