Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: TextWrap opens and closes every HTML tag #2927

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Nov 15, 2023

Before, we were producing invalid HTML/SVG in the footer (origin URL | CC BY) in some very rare cases, like this one here.

@danyx23 danyx23 changed the base branch from 11-09-improve-citation-block to master November 17, 2023 16:05
@danyx23 danyx23 force-pushed the text-wrap-html-tags branch from 8a51cd8 to 0352b27 Compare November 17, 2023 16:05
@danyx23
Copy link
Contributor

danyx23 commented Nov 17, 2023

I accidentally rebased this branch, sorry for the confusion above. It is now current against master again

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I accidentally rebased this PR when I wanted to rebase your bind window PR and graphite with it's trigger happy rebase and force push led to some funky mentions etc showing up now - sorry about that. The PR is now targeting master again and rebased on current master so should be good to merge!

@owid owid deleted a comment from danyx23 Nov 18, 2023
@marcelgerber marcelgerber merged commit 774283c into master Nov 18, 2023
13 checks passed
@marcelgerber marcelgerber deleted the text-wrap-html-tags branch November 18, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants