Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add four columns option to {.people-rows} #4276

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add four columns option to {.people-rows} #4276

merged 3 commits into from
Dec 12, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Dec 10, 2024

image

Also fixes some unrelated styling issues.

@rakyi rakyi requested a review from ikesau December 10, 2024 18:38
@owidbot
Copy link
Contributor

owidbot commented Dec 10, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-people-four-cols

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-10 18:57:28 UTC
Execution time: 1.20 seconds

@rakyi rakyi force-pushed the people-four-cols branch 2 times, most recently from 7c17048 to 193b94b Compare December 11, 2024 15:09
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I didn't test all the new CSS overrides, presumably we can do that in a final pass of the draft pages.

site/gdocs/components/People.tsx Outdated Show resolved Hide resolved
site/gdocs/pages/AboutPage.scss Show resolved Hide resolved
Copy link
Contributor Author

rakyi commented Dec 12, 2024

Copy link
Contributor Author

rakyi commented Dec 12, 2024

Merge activity

  • Dec 12, 4:49 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 12, 4:49 AM EST: A user merged this pull request with Graphite.

@rakyi rakyi merged commit a7d6726 into master Dec 12, 2024
13 of 14 checks passed
@rakyi rakyi deleted the people-four-cols branch December 12, 2024 09:49
@rakyi rakyi linked an issue Dec 12, 2024 that may be closed by this pull request
@rakyi rakyi linked an issue Dec 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add former team members archie block
3 participants