Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dropdown nav for about pages #4290

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add dropdown nav for about pages #4290

merged 1 commit into from
Dec 19, 2024
+57 −21

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Dec 12, 2024

No description provided.

@rakyi rakyi requested a review from ikesau December 12, 2024 13:33
This was referenced Dec 12, 2024
Merged
Merged
@rakyi Graphite App
Copy link
Contributor Author

rakyi commented Dec 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rakyi rakyi marked this pull request as ready for review December 12, 2024 13:33
@owidbot
Copy link
Contributor

owidbot commented Dec 12, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-about-nav

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-12 13:46:00 UTC
Execution time: 1.22 seconds

ikesau
ikesau approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean 🙂

@rakyi rakyi changed the base branch from archie-code to graphite-base/4290 December 12, 2024 15:30
@rakyi rakyi force-pushed the graphite-base/4290 branch from 082daa4 to 5a65e4b Compare December 12, 2024 15:30
@rakyi rakyi changed the base branch from graphite-base/4290 to master December 12, 2024 15:31
@rakyi rakyi force-pushed the about-nav branch 2 times, most recently from 7ef06ed to 9546d6a Compare December 12, 2024 18:39
This was referenced Dec 12, 2024
Merged
Merged
@rakyi rakyi force-pushed the about-nav branch 3 times, most recently from 7e0ae43 to 42cbbf5 Compare December 17, 2024 17:59
@rakyi Graphite App
Copy link
Contributor Author

rakyi commented Dec 19, 2024 •
edited
Loading

Merge activity

  • Dec 19, 11:41 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 11:42 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 19, 11:43 AM EST: A user merged this pull request with Graphite.

@rakyi rakyi merged commit fe8c306 into master Dec 19, 2024
13 of 15 checks passed
@rakyi rakyi deleted the about-nav branch December 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesau ikesau ikesau approved these changes

Assignees

@rakyi rakyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakyi @owidbot @ikesau