-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 use markdown for rendering grouped text wraps / TAS-782 #4402
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 573 (b4f41b) ❌ Edited: 2025-01-21 09:25:36 UTC |
84e6485
to
0f6ed49
Compare
7a1dd77
to
8ce1f76
Compare
0f6ed49
to
d95a8ab
Compare
8ce1f76
to
54f3e88
Compare
d95a8ab
to
721caf1
Compare
54f3e88
to
ea07fb3
Compare
721caf1
to
a5479f3
Compare
ea07fb3
to
3521d4d
Compare
591b9a6
to
73e796d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This is a lesson in "why complicated when it can be easy?" 😄
So many lines of complicated code removed, just because of the realization that we usually need at most two lines of text co-positioned...
I wish I had realised earlier that I could just use MarkdownTextWrap 😅 |
6f37c1c
to
70623f2
Compare
70623f2
to
97cbcc6
Compare
Gets rid of
TextWrapGroup
and instead uses theMarkdownTextWrap
component to implement similar behaviour.I want to use the 'avoid-wrap' behaviour for axis labels and their units, but axis labels support DoDs, so I need Markdown rendering.
This is part 2 of 4 in a stack made with GitButler: