Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add unit to axis labels / TAS-784 #4403

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 8, 2025

Resolves #4362

Appends the unit to axis labels in parens, like "label (unit)".

The next PR makes it so that for axis labels that have parens, like Human Development Index (male), only the first part (Human Development Index) is made bold. It looks nicer.


This is part 3 of 4 in a stack made with GitButler:

@sophiamersmann sophiamersmann changed the title ✨ add unit to axis labels ✨ add unit to axis labels / TAS-784 Jan 8, 2025
Copy link

Add unit to axis labels

@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 8, 2025
@owidbot
Copy link
Contributor

owidbot commented Jan 8, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-axis-label-unit

SVG tester:

Number of differences (default views): 653 (58374f) ❌
Number of differences (all views): 653 (12a7a4) ❌

Edited: 2025-01-21 12:51:44 UTC
Execution time: 1.22 seconds

@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 7a1dd77 to 8ce1f76 Compare January 9, 2025 11:59
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 8ce1f76 to 54f3e88 Compare January 9, 2025 12:52
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 54f3e88 to ea07fb3 Compare January 9, 2025 15:09
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from ea07fb3 to 3521d4d Compare January 13, 2025 09:50
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 3521d4d to f40c06a Compare January 13, 2025 12:12
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from f40c06a to 03ad582 Compare January 13, 2025 14:25
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 03ad582 to 1a5dbd6 Compare January 13, 2025 14:26
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 1a5dbd6 to 591b9a6 Compare January 13, 2025 14:31
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 591b9a6 to 73e796d Compare January 13, 2025 14:42
@sophiamersmann sophiamersmann marked this pull request as ready for review January 13, 2025 15:42
@sophiamersmann sophiamersmann marked this pull request as draft January 20, 2025 09:52
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 73e796d to 6f37c1c Compare January 21, 2025 08:13
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch 2 times, most recently from 70623f2 to 97cbcc6 Compare January 21, 2025 08:56
Base automatically changed from markdown-text-wrap-group to master January 21, 2025 11:12
@sophiamersmann sophiamersmann marked this pull request as ready for review January 21, 2025 12:49
@sophiamersmann sophiamersmann merged commit 0e82170 into master Jan 21, 2025
23 checks passed
@sophiamersmann sophiamersmann deleted the axis-label-unit branch January 21, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit to axis labels
2 participants