Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/class-properties): remove defunct comments #7527

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 28, 2024

These comments are out of date / repeated elsewhere.

Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2024
Copy link
Contributor Author

overlookmotel commented Nov 28, 2024

@overlookmotel overlookmotel marked this pull request as ready for review November 28, 2024 16:24
@overlookmotel
Copy link
Contributor Author

Only affects comment, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
Copy link
Contributor Author

overlookmotel commented Nov 28, 2024

Merge activity

  • Nov 28, 11:25 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 11:31 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 28, 11:37 AM EST: A user merged this pull request with the Graphite merge queue.

These comments are out of date / repeated elsewhere.
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_remove_defunct_comments branch from 0f337e5 to d5aaee7 Compare November 28, 2024 16:30
@graphite-app graphite-app bot merged commit d5aaee7 into main Nov 28, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_transformer_class-properties_remove_defunct_comments branch November 28, 2024 16:37
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7527 will not alter performance

Comparing 11-28-refactor_transformer_class-properties_remove_defunct_comments (d5aaee7) with main (6655345)

Summary

✅ 30 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant