Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_structures): add SparseStack::last_mut method #7528

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 28, 2024

Add SparseStack::last_mut method, as companion to SparseStack::last.

Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Nov 28, 2024

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 28, 2024
@overlookmotel overlookmotel changed the base branch from 11-28-refactor_transformer_class-properties_remove_defunct_comments to graphite-base/7528 November 28, 2024 16:30
@overlookmotel overlookmotel marked this pull request as ready for review November 28, 2024 16:31
@overlookmotel
Copy link
Contributor Author

I think I understand the stack types better than anyone else at present, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
Copy link
Contributor Author

overlookmotel commented Nov 28, 2024

Merge activity

  • Nov 28, 11:32 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 11:36 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 28, 11:45 AM EST: A user merged this pull request with the Graphite merge queue.

Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7528 will not alter performance

Comparing 11-28-feat_data_structures_add_sparsestack_last_mut_method (defaf4b) with main (d5aaee7)

Summary

✅ 30 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/7528 to main November 28, 2024 16:38
@graphite-app graphite-app bot requested a review from Dunqing as a code owner November 28, 2024 16:38
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 28, 2024
Add `SparseStack::last_mut` method, as companion to `SparseStack::last`.
@overlookmotel overlookmotel force-pushed the 11-28-feat_data_structures_add_sparsestack_last_mut_method branch from 5203c82 to defaf4b Compare November 28, 2024 16:39
@graphite-app graphite-app bot merged commit defaf4b into main Nov 28, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-28-feat_data_structures_add_sparsestack_last_mut_method branch November 28, 2024 16:45
@overlookmotel
Copy link
Contributor Author

@Boshen Any idea why Dunqing was requested as reviewer on this PR? It doesn't touch any of the crates he's listed as owner of. Is this a bug in Graphite? Or have we configured it wrong?

@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant