[Audio] Replace Title BGM with custom BGM by Firel #5189
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added descriptions for the battle scene and arena's getBgmLoopPoint methods.
damocleas
previously approved these changes
Jan 26, 2025
Adri1
previously approved these changes
Jan 26, 2025
DayKev
previously approved these changes
Jan 26, 2025
DayKev
added
the
Awaiting Locales
Madmadness65
dismissed stale reviews from DayKev, Adri1, and damocleas
via
8a2ae0a
DayKev
approved these changes
Jan 27, 2025
damocleas
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Replaces the PMD Top Menu music with a custom track made by Firel.
Why am I making these changes?
The PMD title music was a temporary replacement until we got another unique title theme again.
What are the changes from a developer perspective?
Replaced audio file, added a loop point entry for the title track, as well as added some documentation for the
getBgmLoopPointmethods in the battle scene and arena files.Screenshots/Videos
title.mp4
How to test the changes?
Go to the main menu.
Checklist
betaas my base branchnpm run test)- [ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?- [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?Are there any localization additions or changes? If so: