Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Replace Title BGM with custom BGM by Firel #5189

Merged
merged 3 commits into from
Jan 30, 2025
Merged

[Audio] Replace Title BGM with custom BGM by Firel #5189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15f88fc
Replace Title BGM with custom BGM by Firel
Madmadness65 Jan 26, 2025
8a2ae0a
Upload fixed version of title music
Madmadness65 Jan 26, 2025
1e6c74a
Merge branch 'beta' into bgm-changes
damocleas Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified public/audio/bgm/title.mp3
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions src/battle-scene.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,8 +2084,11 @@ export default class BattleScene extends SceneBase {
return sound;
}

/** The loop point of any given battle, mystery encounter, or title track, read as seconds and milliseconds. */
getBgmLoopPoint(bgmName: string): number {
switch (bgmName) {
case "title": //Firel PokéRogue Title
return 46.500;
case "battle_kanto_champion": //B2W2 Kanto Champion Battle
return 13.950;
case "battle_johto_champion": //B2W2 Johto Champion Battle
Expand Down
1 change: 1 addition & 0 deletions src/field/arena.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ export class Arena {
globalScene.loadBgm(this.bgm);
}

/** The loop point of any given biome track, read as seconds and milliseconds. */
getBgmLoopPoint(): number {
switch (this.biomeType) {
case Biome.TOWN:
Expand Down