[API] Rework the return of a compiler to avoid async and make target optional.
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
force-pushed
the
yoric/loaders-await
branch
from
05d0166 to
2c8265c
Compare
RolandMacDoland
approved these changes
Jan 30, 2025
RolandMacDoland
approved these changes
Jan 30, 2025
…et` optional. We don't want our users to need to understand `async`/`await` until they need to, so we rework the output of extractors to make them usable without `async`/`await`. Only users who write code for servers or interactive applications will need to `await`. Also, we make `target` optional, because we want to be able to use our kernel with data that does not come from the training material! Note: breaking API changes, we'll need to bump version.
Yoric
force-pushed
the
yoric/loaders-await
branch
from
7eb786d to
bebd7b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want our users to need to understand
async/awaituntil they need to,so we rework the output of extractors to make them usable without
async/await.Only users who write code for servers or interactive applications will need to
await.Also, we make
targetoptional, because we want to be able to use our kernel withdata that does not come from the training material!
Note: breaking API changes, we'll need to bump version.