Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves extrapolation #49

Merged
merged 4 commits into from
Apr 19, 2020
Merged

Improves extrapolation #49

merged 4 commits into from
Apr 19, 2020

Conversation

Berkmann18
Copy link
Collaborator

Turns the handPose features into null as soon it sees there are none (i.e. the hands aren't visible). This way, as soon as no hands are visible, the hand-related computations (namely the inference computation) will be skipped (therefore increasing the post-boot-up performance).

Note: There are still some areas to look at tho (see my review comments on here and new TODO)

public/js/draw.js Outdated Show resolved Hide resolved
public/js/main.js Outdated Show resolved Hide resolved
@Berkmann18 Berkmann18 requested a review from AndyJiang99 April 10, 2020 18:13
@Berkmann18 Berkmann18 mentioned this pull request Apr 10, 2020
9 tasks
Copy link
Owner

@peddybeats peddybeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maxie!

public/js/draw.js Outdated Show resolved Hide resolved
public/js/main.js Outdated Show resolved Hide resolved
public/js/main.js Outdated Show resolved Hide resolved
public/js/main.js Outdated Show resolved Hide resolved
@peddybeats peddybeats merged commit cc25d4f into master Apr 19, 2020
@peddybeats peddybeats deleted the extrapol branch April 19, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants