feat(abbreviations): use wof:abbreviation for dependencies if available #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backwards-compatible version of #273 which allows us to handle the upcoming switch from storing dependency abbreviations in the `wof:country` field to `wof:abbreviation` (see whosonfirst-data/whosonfirst-data#823) It should be safe to merge now and will do the right thing once WOF data is updated. Supersedes #273
|
Note: lets merge #374 first since they touch similar parts of the code. |
orangejulius
pushed a commit
that referenced
this pull request
Sep 19, 2018
Several abbreviation fields have changed or will change over time in WOF. 1.) `wof:shortcode` just replaced `wof:abbreviation` 2.) for dependency records, `wof:shortcode` will replace `wof:country` This change allows us to handle both of those changing fields in a backwrds compatible way, by supporting the older field but prioritizing the newer ones. We should later come in and remove the logic to refer to the older values once we're sure they're no longer used and enough time has passed that most people will have updated their copy of WOF data. Supersedes #273 Supersedes #375 Fixes #398 Fixes pelias/pelias#645 Connects whosonfirst/whosonfirst-properties#78
orangejulius
pushed a commit
that referenced
this pull request
Sep 19, 2018
Several abbreviation fields have changed or will change over time in WOF. 1.) `wof:shortcode` just replaced `wof:abbreviation` 2.) for dependency records, `wof:shortcode` will replace `wof:country` This change allows us to handle both of those changing fields in a backwards compatible way, by supporting the older field but prioritizing the newer ones. We should later come in and remove the logic to refer to the older values once we're sure they're no longer used and enough time has passed that most people will have updated their copy of WOF data. Supersedes #273 Supersedes #375 Fixes #398 Fixes pelias/pelias#645 Connects whosonfirst/whosonfirst-properties#78
orangejulius
added a commit
that referenced
this pull request
Sep 19, 2018
Several abbreviation fields have changed or will change over time in WOF. 1.) `wof:shortcode` just replaced `wof:abbreviation` 2.) for dependency records, `wof:shortcode` will replace `wof:country` This change allows us to handle both of those changing fields in a backwards compatible way, by supporting the older field but prioritizing the newer ones. We should later come in and remove the logic to refer to the older values once we're sure they're no longer used and enough time has passed that most people will have updated their copy of WOF data. Supersedes #273 Supersedes #375 Fixes #398 Fixes pelias/pelias#645 Connects whosonfirst/whosonfirst-properties#78
|
replaced with #399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards-compatible version of #273 which allows us to handle the upcoming switch from storing dependency abbreviations in the
wof:countryfield towof:abbreviation(see whosonfirst-data/whosonfirst-data#823)It should be safe to merge now and will do the right thing once WOF data is updated.
Supersedes #273