Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dividing by Zero errors #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bourdeaa
Copy link

@Bourdeaa Bourdeaa commented Nov 1, 2024

This feature adds illegalArgumentException handling for divisors of 0. This exception is thrown for each method regardless of how the division is obtained. The method of using Exceptions is useful as future development allows for change in the exception handling, futureproofing the code to change how we want to handle division by 0 errors.

@@ -3,6 +3,11 @@
public class Division {

public static final long division(int a, int b) {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

@@ -11,6 +16,10 @@ public static final long divisionUsingLoop(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

@@ -25,6 +34,10 @@ public static final long divisionUsingRecursion(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

@@ -41,6 +54,10 @@ public static final long divisionUsingMultiplication(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

@@ -59,6 +76,10 @@ public static final long divisionUsingShift(int a, int b) {
int absB = Math.abs(b);
int tempA, tempB, counter;

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

@@ -78,6 +99,11 @@ public static final long divisionUsingShift(int a, int b) {
public static final long divisionUsingLogs(int a, int b) {
long absA = Math.abs(a);
long absB = Math.abs(b);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

Copy link
Author

@Bourdeaa Bourdeaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note comments for each change in the PR

Copy link
Author

@Bourdeaa Bourdeaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant