Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dividing by Zero errors #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Dividing by Zero errors #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/com/jwetherell/algorithms/mathematics/Division.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
public class Division {

public static final long division(int a, int b) {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

long result = ((long) a) / ((long) b);
return result;
}
Expand All @@ -11,6 +16,10 @@ public static final long divisionUsingLoop(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

throw new IllegalArgumentException("Divisor cannot be zero.");
}

long temp = absA;
long result = 0;
while (temp >= 0) {
Expand All @@ -25,6 +34,10 @@ public static final long divisionUsingRecursion(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

throw new IllegalArgumentException("Divisor cannot be zero.");
}

long result = 1;
int diff = absA - absB;
if (diff > 0 && diff <= 1) {
Expand All @@ -41,6 +54,10 @@ public static final long divisionUsingMultiplication(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

throw new IllegalArgumentException("Divisor cannot be zero.");
}

int temp = absB;
int counter = 0;
while (temp <= absA) {
Expand All @@ -59,6 +76,10 @@ public static final long divisionUsingShift(int a, int b) {
int absB = Math.abs(b);
int tempA, tempB, counter;

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

throw new IllegalArgumentException("Divisor cannot be zero.");
}

long result = 0L;
while (absA >= absB) {
tempA = absA >> 1; // Right shift "a"
Expand All @@ -78,6 +99,11 @@ public static final long divisionUsingShift(int a, int b) {
public static final long divisionUsingLogs(int a, int b) {
long absA = Math.abs(a);
long absB = Math.abs(b);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method will throw an exception by ensuring the value of b before the result "long" is calculated avoiding unexpected results.

if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

double logBase10A = Math.log10(absA);
double logBase10B = Math.log10(absB);
double powOf10 = Math.pow(10, (logBase10A - logBase10B));
Expand Down