Command line tools for XML sync testing between languages #222
+616
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Feb 21, 2025
| if ( implode( "\n" , $s ) == implode( "\n" , $t ) ) | ||
| continue; | ||
|
|
||
| $sideCount = array(); |
There was a problem hiding this comment.
Suggested change
| $sideCount = array(); | |
| $sideCount = []; |
|
|
||
| function extractPiData( array $list ) | ||
| { | ||
| $ret = array(); |
There was a problem hiding this comment.
Suggested change
| $ret = array(); | |
| $ret = []; |
Comment on lines
+48
to
+50
| foreach( $s as $v ) | ||
| $sideCount[$v] = [ 0 , 0 ]; | ||
| foreach( $t as $v ) |
There was a problem hiding this comment.
I don't understand this coding style. Usually it would be something like:
Suggested change
| foreach( $s as $v ) | |
| $sideCount[$v] = [ 0 , 0 ]; | |
| foreach( $t as $v ) | |
| foreach ($s as $v) | |
| $sideCount[$v] = [ 0 , 0 ]; | |
| foreach ($t as $v) |
| continue; | ||
|
|
||
| print "# qaxml.r: $target\n"; | ||
| foreach( $revtag->errors as $error ) |
| if ( implode( "\n" , $s ) == implode( "\n" , $t ) ) | ||
| continue; | ||
|
|
||
| $sideCount = array(); |
There was a problem hiding this comment.
Suggested change
| $sideCount = array(); | |
| $sideCount = []; |
|
|
||
| function extractTagsInnerText( array $nodes , array $tags ) | ||
| { | ||
| $ret = array(); |
There was a problem hiding this comment.
Suggested change
| $ret = array(); | |
| $ret = []; |
| if ( in_array( $tag , $tags ) == false ) | ||
| continue; | ||
| $text = $node->textContent; | ||
| while( true ) |
There was a problem hiding this comment.
Similarly CS which I don't understand.
|
|
||
| function extractTagsInnerXmls( array $nodes , array $tags ) | ||
| { | ||
| $ret = array(); |
Comment on lines
+278
to
+280
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
Why?
Suggested change
| } | |
| else | |
| { | |
| } else { |
|
|
||
| function collectTagLines( string $file , string $tag ) | ||
| { | ||
| $ret = array(); |
| $s = extractPiData( $s ); | ||
| $t = extractPiData( $t ); | ||
|
|
||
| if ( implode( "\n" , $s ) == implode( "\n" , $t ) ) |
There was a problem hiding this comment.
Shouldn't this be ===? I think it would make more sense.
| $target = $file->targetDir . '/' . $file->file; | ||
| $output = new OutputBuffer( "# qaxml.p" , $target , $ignore ); | ||
|
|
||
| [ $s , $_ , $_ ] = XmlFrag::loadXmlFragmentFile( $source ); |
There was a problem hiding this comment.
Why are you reusing the variable $_ twice? It's just going to overwrite it. And I don't think you are actually using this variable anywhere so why assign it at all?
Comment on lines
+37
to
+38
| $s = XmlFrag::listNodes( $s , XML_PI_NODE ); | ||
| $t = XmlFrag::listNodes( $t , XML_PI_NODE ); |
There was a problem hiding this comment.
Suggested change
| $s = XmlFrag::listNodes( $s , XML_PI_NODE ); | |
| $t = XmlFrag::listNodes( $t , XML_PI_NODE ); | |
| $s = XmlFrag::listNodes( $s , XML_PI_NODE ); | |
| $t = XmlFrag::listNodes( $t , XML_PI_NODE ); |
Suggested change
| $s = XmlFrag::listNodes( $s , XML_PI_NODE ); | |
| $t = XmlFrag::listNodes( $t , XML_PI_NODE ); | |
| $source = XmlFrag::listNodes( $source , XML_PI_NODE ); | |
| $target = XmlFrag::listNodes( $target , XML_PI_NODE ); |
Please don't use single-character variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the last of old qaxml tools into something that is almost independent of "lib revcheck" code, and adapted to be run in all translations.
After this PR is merged, and new tools announced, the old tools/code removing will be possible. The only dependence renaming are
/lib/RevtagParser.php, that is a isolated file, andSyncFileListcalling intoRevcheckRun, that can be replaced with a simple.xmllisting, as the new tools now inspect all files, and does not filter forTranslatedOkanymore.