Command line tools for XML sync testing between languages #222
+616
−71
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,71 @@ | ||||||||||||||||||
| <?php /* | ||||||||||||||||||
| +----------------------------------------------------------------------+ | ||||||||||||||||||
| | Copyright (c) 1997-2025 The PHP Group | | ||||||||||||||||||
| +----------------------------------------------------------------------+ | ||||||||||||||||||
| | This source file is subject to version 3.01 of the PHP license, | | ||||||||||||||||||
| | that is bundled with this package in the file LICENSE, and is | | ||||||||||||||||||
| | available through the world-wide-web at the following url: | | ||||||||||||||||||
| | https://www.php.net/license/3_01.txt. | | ||||||||||||||||||
| | If you did not receive a copy of the PHP license and are unable to | | ||||||||||||||||||
| | obtain it through the world-wide-web, please send a note to | | ||||||||||||||||||
| | [email protected], so we can mail you a copy immediately. | | ||||||||||||||||||
| +----------------------------------------------------------------------+ | ||||||||||||||||||
| | Authors: André L F S Bacci <ae php.net> | | ||||||||||||||||||
| +----------------------------------------------------------------------+ | ||||||||||||||||||
|
|
||||||||||||||||||
| # Description | ||||||||||||||||||
|
|
||||||||||||||||||
| Compare processing instructions usage between two XML files. */ | ||||||||||||||||||
|
|
||||||||||||||||||
| require_once __DIR__ . '/libqa/all.php'; | ||||||||||||||||||
|
|
||||||||||||||||||
| $argv = new ArgvParser( $argv ); | ||||||||||||||||||
| $ignore = new OutputIgnore( $argv ); // may exit. | ||||||||||||||||||
| $argv->complete(); | ||||||||||||||||||
|
|
||||||||||||||||||
| $list = SyncFileList::load(); | ||||||||||||||||||
|
|
||||||||||||||||||
| foreach ( $list as $file ) | ||||||||||||||||||
| { | ||||||||||||||||||
| $source = $file->sourceDir . '/' . $file->file; | ||||||||||||||||||
| $target = $file->targetDir . '/' . $file->file; | ||||||||||||||||||
| $output = new OutputBuffer( "# qaxml.p" , $target , $ignore ); | ||||||||||||||||||
|
|
||||||||||||||||||
| [ $s , $_ , $_ ] = XmlFrag::loadXmlFragmentFile( $source ); | ||||||||||||||||||
| [ $t , $_ , $_ ] = XmlFrag::loadXmlFragmentFile( $target ); | ||||||||||||||||||
|
|
||||||||||||||||||
| $s = XmlFrag::listNodes( $s , XML_PI_NODE ); | ||||||||||||||||||
| $t = XmlFrag::listNodes( $t , XML_PI_NODE ); | ||||||||||||||||||
|
Comment on lines
+37
to
+38
There was a problem hiding this comment.
Suggested change
Suggested change
Please don't use single-character variable names. |
||||||||||||||||||
|
|
||||||||||||||||||
| $s = extractPiData( $s ); | ||||||||||||||||||
| $t = extractPiData( $t ); | ||||||||||||||||||
|
|
||||||||||||||||||
| if ( implode( "\n" , $s ) == implode( "\n" , $t ) ) | ||||||||||||||||||
|
There was a problem hiding this comment. Shouldn't this be |
||||||||||||||||||
| continue; | ||||||||||||||||||
|
|
||||||||||||||||||
| $sideCount = array(); | ||||||||||||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| foreach( $s as $v ) | ||||||||||||||||||
| $sideCount[$v] = [ 0 , 0 ]; | ||||||||||||||||||
| foreach( $t as $v ) | ||||||||||||||||||
|
Comment on lines
+48
to
+50
There was a problem hiding this comment. I don't understand this coding style. Usually it would be something like:
Suggested change
|
||||||||||||||||||
| $sideCount[$v] = [ 0 , 0 ]; | ||||||||||||||||||
|
|
||||||||||||||||||
| foreach( $s as $v ) | ||||||||||||||||||
| $sideCount[$v][0] += 1; | ||||||||||||||||||
| foreach( $t as $v ) | ||||||||||||||||||
| $sideCount[$v][1] += 1; | ||||||||||||||||||
|
|
||||||||||||||||||
| foreach( $sideCount as $k => $v ) | ||||||||||||||||||
| if ( $v[0] != $v[1] ) | ||||||||||||||||||
| $output->addDiff( $k , $v[0] , $v[1] ); | ||||||||||||||||||
|
|
||||||||||||||||||
| $output->print(); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| function extractPiData( array $list ) | ||||||||||||||||||
| { | ||||||||||||||||||
| $ret = array(); | ||||||||||||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||
| foreach( $list as $elem ) | ||||||||||||||||||
| $ret[] = "{$elem->target} {$elem->data}"; | ||||||||||||||||||
| return $ret; | ||||||||||||||||||
| } | ||||||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you reusing the variable
$_twice? It's just going to overwrite it. And I don't think you are actually using this variable anywhere so why assign it at all?