Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: optimize stats delta dumping with batch processing #59150

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jan 23, 2025

What problem does this PR solve?

Issue Number: ref #57869

close #58890
close #58884
close #58885
close #58993
close #59022
close #59120
close #59139

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 75.52448% with 70 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@722347b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #59150   +/-   ##
================================================
  Coverage               ?   56.8947%           
================================================
  Files                  ?       1769           
  Lines                  ?     627453           
  Branches               ?          0           
================================================
  Hits                   ?     356988           
  Misses                 ?     246379           
  Partials               ?      24086           
Flag Coverage Δ
integration 36.9082% <65.0349%> (?)
unit 72.5918% <72.7272%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2934% <0.0000%> (?)

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-dump-historical-stats-for-8.5 branch from d8575ab to 6117d70 Compare January 23, 2025 07:12
@Rustin170506 Rustin170506 requested a review from winoros January 23, 2025 08:30
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 08:31:07.747336593 +0000 UTC m=+342395.078255999: ☑️ agreed by GMHDBJD.
  • 2025-01-23 09:05:03.117227272 +0000 UTC m=+344430.448146677: ☑️ agreed by yudongusa.

Copy link

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, qw4990, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit b313166 into pingcap:release-8.5 Jan 23, 2025
18 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-dump-historical-stats-for-8.5 branch January 23, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants