Added DTLS-SRTP IDs for NULL and AES256CM ciphers (V2 CP) #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTLS server checks this list during handshake. Without this change new NULL and AES256CM SRTP ciphers were ignored.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #653 +/- ##
=====================================
Coverage ? 78.74%
=====================================
Files ? 95
Lines ? 4715
Branches ? 0
=====================================
Hits ? 3713
Misses ? 662
Partials ? 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DTLS-SRTP IDs for NULL and AES256CM ciphers
Mark NULL and AES256CM SRTP ciphers as supported
DTLS server checks this list during handshake. Without this change new
NULL and AES256CM SRTP ciphers were ignored.
This is V2 CP of PRs from master.