Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DTLS-SRTP IDs for NULL and AES256CM ciphers (V2 CP) #653

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Added DTLS-SRTP IDs for NULL and AES256CM ciphers (V2 CP) #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ae00f0
Added DTLS-SRTP IDs for NULL and AES256CM ciphers
sirzooro Jul 13, 2024
2f1aa70
Mark NULL and AES256CM SRTP ciphers as supported
sirzooro Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/protocol/extension/srtp_protection_profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
const (
SRTP_AES128_CM_HMAC_SHA1_80 SRTPProtectionProfile = 0x0001 // nolint
SRTP_AES128_CM_HMAC_SHA1_32 SRTPProtectionProfile = 0x0002 // nolint
SRTP_AES256_CM_SHA1_80 SRTPProtectionProfile = 0x0003 // nolint
SRTP_AES256_CM_SHA1_32 SRTPProtectionProfile = 0x0004 // nolint
SRTP_NULL_HMAC_SHA1_80 SRTPProtectionProfile = 0x0005 // nolint
SRTP_NULL_HMAC_SHA1_32 SRTPProtectionProfile = 0x0006 // nolint
SRTP_AEAD_AES_128_GCM SRTPProtectionProfile = 0x0007 // nolint
SRTP_AEAD_AES_256_GCM SRTPProtectionProfile = 0x0008 // nolint
)
Expand All @@ -18,6 +22,10 @@
return map[SRTPProtectionProfile]bool{
SRTP_AES128_CM_HMAC_SHA1_80: true,
SRTP_AES128_CM_HMAC_SHA1_32: true,
SRTP_AES256_CM_SHA1_80: true,
SRTP_AES256_CM_SHA1_32: true,
SRTP_NULL_HMAC_SHA1_80: true,
SRTP_NULL_HMAC_SHA1_32: true,

Check warning on line 28 in pkg/protocol/extension/srtp_protection_profile.go

View check run for this annotation

Codecov / codecov/patch

pkg/protocol/extension/srtp_protection_profile.go#L25-L28 

Added lines #L25 - L28 were not covered by tests
SRTP_AEAD_AES_128_GCM: true,
SRTP_AEAD_AES_256_GCM: true,
}
Expand Down
4 changes: 4 additions & 0 deletions srtp_protection_profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ type SRTPProtectionProfile = extension.SRTPProtectionProfile
const (
SRTP_AES128_CM_HMAC_SHA1_80 SRTPProtectionProfile = extension.SRTP_AES128_CM_HMAC_SHA1_80 // nolint:revive,stylecheck
SRTP_AES128_CM_HMAC_SHA1_32 SRTPProtectionProfile = extension.SRTP_AES128_CM_HMAC_SHA1_32 // nolint:revive,stylecheck
SRTP_AES256_CM_SHA1_80 SRTPProtectionProfile = extension.SRTP_AES256_CM_SHA1_80 // nolint:revive,stylecheck
SRTP_AES256_CM_SHA1_32 SRTPProtectionProfile = extension.SRTP_AES256_CM_SHA1_32 // nolint:revive,stylecheck
SRTP_NULL_HMAC_SHA1_80 SRTPProtectionProfile = extension.SRTP_NULL_HMAC_SHA1_80 // nolint:revive,stylecheck
SRTP_NULL_HMAC_SHA1_32 SRTPProtectionProfile = extension.SRTP_NULL_HMAC_SHA1_32 // nolint:revive,stylecheck
SRTP_AEAD_AES_128_GCM SRTPProtectionProfile = extension.SRTP_AEAD_AES_128_GCM // nolint:revive,stylecheck
SRTP_AEAD_AES_256_GCM SRTPProtectionProfile = extension.SRTP_AEAD_AES_256_GCM // nolint:revive,stylecheck
)
Loading