Added support for AES CM 256 crypto suites #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 78.83% 78.91% +0.08%
==========================================
Files 17 17
Lines 992 996 +4
==========================================
+ Hits 782 786 +4
Misses 118 118
Partials 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sirzooro
force-pushed
the
add_support_for_aes_cm_256
branch
from
c2a74d5 to
d87f5d1
Compare
at-wat
reviewed
Jul 11, 2024
protection_profile.go
Outdated
Comment on lines
19
to
21
| // These are not IANA registered, so used high values to avoid potential conflict | ||
| ProtectionProfileAes256CmHmacSha1_80 ProtectionProfile = 0xfff0 | ||
| ProtectionProfileAes256CmHmacSha1_32 ProtectionProfile = 0xfff1 |
There was a problem hiding this comment.
In the RFC draft,
SRTPProtectionProfile SRTP_AES256_CM_SHA1_80 = {0x00, 0x03};
SRTPProtectionProfile SRTP_AES256_CM_SHA1_32 = {0x00, 0x04};
https://datatracker.ietf.org/doc/html/draft-ietf-avt-dtls-srtp-03#section-4.1.2
libsrtp in chromium code seems also using them: https://chromium.googlesource.com/chromium/deps/libsrtp/+/84122798bb16927b1e676bd4f938a6e48e5bf2fe/srtp/include/srtp.h#694
There was a problem hiding this comment.
Thanks for info! Updated this in code.
Added support for AES_256_CM_HMAC_SHA1_80 and AES_256_CM_HMAC_SHA1_32 crypto suites.
sirzooro
force-pushed
the
add_support_for_aes_cm_256
branch
from
d87f5d1 to
59e8b1e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for AES_256_CM_HMAC_SHA1_80 and AES_256_CM_HMAC_SHA1_32 crypto suites.
Reference encrypted packets used in tests are the same as generated by libsrtp2.