Allow clang and gcc builds for src/e2e_test/vizier/planner:planner_test
#2077
Conversation
| @@ -458,4 +458,7 @@ message StackTraceFlameGraph { | |||
| string node_column = 8; | |||
| // The label for the percentage. | |||
| string percentage_label = 9; | |||
| // The column containing the stacktrace's delta. This is only relevant for differential | |||
| // flamegraphs. | |||
| string difference_column = 10; | |||
There was a problem hiding this comment.
The recent differential flamegraph changes weren't made to this file. Without this change, the test target fails with the following error:
$ bazel test -c dbg src/e2e_test/vizier/planner:planner_test --test_output=all
INFO: From Testing //src/e2e_test/vizier/planner:planner_test:
==================== Test output for //src/e2e_test/vizier/planner:planner_test:
--- FAIL: TestAllScriptsCompile (0.04s)
all_scripts_test.go:322:
Error Trace: src/e2e_test/vizier/planner/all_scripts_test.go:322
Error: Received unexpected error:
can't unmarshal Any nested proto *vispb.StackTraceFlameGraph: unknown field "differenceColumn" in vispb.StackTraceFlameGraph
Test: TestAllScriptsCompile
FAIL
The flamegraph script has been in a cloud release for a while now and I've used it extensively, so it appears that only the e2e tests here use this proto. Typescript does match on the proto package name, but it has its own data structure for working with it.
ddelnano
changed the title
src/e2e_test/vizier/planner:planner_test
ddelnano
changed the title
src/e2e_test/vizier/planner:planner_testsrc/e2e_test/vizier/planner:planner_test
ddelnano
force-pushed
the
ddelnano/fix-all-scripts-tests
branch
from
d96d31a to
2ac771d
Compare
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/fix-all-scripts-tests
branch
from
2ac771d to
91a56ea
Compare
| @@ -24,8 +24,6 @@ pl_go_test( | |||
| ], | |||
| tags = [ | |||
| "no_asan", | |||
| "no_gcc", | |||
| "no_libcpp", | |||
There was a problem hiding this comment.
Did you check if it works with libcpp?
There was a problem hiding this comment.
bazel build (without specifying a --config) couldn't find this test target until the no_libcpp was removed. Therefore I thought using libcpp was the default, however, I've tested that --config clang results in a successful build as well.
Summary: Allow clang and gcc builds for
src/e2e_test/vizier/planner:planner_testAs far as I can tell, there isn't a bazel config that matches the tags of the
src/e2e_test/vizier/planner:planner_testtarget. This change removes the tag preventing clang builds since they appear to run without problems. In addition to this, avispbproto change was missing from the earlier differential flamegraph work. This prevented theplanner_testfrom running properly (see comment for more details).Relevant Issues: N/A
Type of change: /kind bugfix
Test Plan: Verified gcc and clang builds work
bazel test --config clang src/e2e_test/vizier/planner:planner_testis successfulbazel test -c opt --config gcc src/e2e_test/vizier/planner:planner_testis successful