Add interprocedural dataset support #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
khatchad
commented
Jan 3, 2024
•
khatchad
commented
- Fallback to interprocedural analysis if we can't find the dataset iterable using intraprocedural analysis.
- Fix several test bugs.
If the dataset iterable can't be found using intraprodecudral analysis, use interprocedural.
khatchad
added a commit
that referenced
this pull request
Jan 29, 2024
* Warn if we can't find the iterable definition. * Fix comment. * Actually check parameters. * Add interprocedural dataset test. * Fallback to interprocedal analysis for datasets. If the dataset iterable can't be found using intraprodecudral analysis, use interprocedural. * Apply spotless. * Add a hybrid dataset test case. * Actually check the parameter value numbers.
Merged
khatchad
added a commit
to wala/ML
that referenced
this pull request
Jan 30, 2024
- Investigate decorator issue on tutorial code (ponder-lab#68) - Fix comment. - Add interprocedural dataset support (ponder-lab#69) - Change log from warning to info. - Add support for non-scalar datasets (ponder-lab#70) - Use interprocedural analysis for property read case. - Add logging. - Fix non-scalar determination. - Add logger. - Fix logger. - Add logging around callable workaround. - Handle callables with lexical scoping. - Formatting. - Handle possible null receivers in callable lookup. - Change log message. - Add log. - Add the ability to process datasets coming out of enumerate() (ponder-lab#71) - Fix tests for input files with multiple functions. - Enhance TF2 tests (ponder-lab#73) - Separate tests by calling context (ponder-lab#74) - Add tf.keras.layers.Dense. - Move comment. - Additional check. - New API. - Add autoencoder test. - Move the value number check outside the context loop. - More the sigmoid function to math. - Format. - Add API tf.add(). - Check the context/funciton PK mappings. (ponder-lab#77) - Add URL. - Add dataset generator and test. - tf.nn.softmax isn't a tensor generator. - Add URL. - Apply spotless. - Let's make the two tests only diff in the invocation. - Prevent infinite recursion when processing instructions when finding tensor data flow sources. - When we look for dataset tensor sources, we recurse up to the original defining instruction. However, there's a possibility that instructions have mutually recursive definitions due to the phi instruction. Let's prevent against that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.