Add seasons infrastructure and basic display #9648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into spotlights-seasons
|
am i doing something wrong or is lint just having a stroke 🤨 |
|
It means the new code added more warnings; we set a max limit on warnings for existing code, new code should not be adding lint errors or new warnings. If running |
|
EDIT: Apparently had a wrong node version installed in my environment for some reason 😅, changing to the right one fixed the issue. |
Fix store line item closing tag
… into spotlights-seasons
|
remember to never use git rebase irresponsibly! replaced by #9725 as it's probably way easier than fixing this one =D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(a big) part of #8736 ✨