Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seasons infrastructure and basic display #9725

Merged
merged 50 commits into from
Feb 3, 2023
Merged

Add seasons infrastructure and basic display #9725

merged 50 commits into from
Feb 3, 2023

Conversation

venix12
Copy link
Member

@venix12 venix12 commented Jan 10, 2023

replaces #9648

(a big) part of #8736 ✨

image

@venix12 venix12 mentioned this pull request Jan 10, 2023
Closed
nanaya
nanaya requested changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to fix merge conflicts

(and I haven't checked the frontend part much)

app/Models/Season.php Outdated Show resolved Hide resolved
app/Models/Season.php Outdated Show resolved Hide resolved
app/Models/Season.php Outdated Show resolved Hide resolved
database/migrations/2022_12_16_151601_create_season_rooms_table.php Outdated Show resolved Hide resolved
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
nanaya
nanaya requested changes Jan 31, 2023
View reviewed changes
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
app/Transformers/SeasonTransformer.php Outdated Show resolved Hide resolved
app/Models/Season.php Outdated Show resolved Hide resolved
database/migrations/2022_12_16_151601_create_season_rooms_table.php Outdated Show resolved Hide resolved
resources/css/bem-index.less Show resolved Hide resolved
resources/js/interfaces/multiplayer-list-json.ts Outdated Show resolved Hide resolved
app/Models/Multiplayer/Room.php Outdated Show resolved Hide resolved
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
resources/js/components/multiplayer-room.tsx Outdated Show resolved Hide resolved
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
nanaya
nanaya requested changes Feb 1, 2023
View reviewed changes
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
app/Models/Multiplayer/Room.php Outdated Show resolved Hide resolved
app/Models/Multiplayer/Room.php Outdated Show resolved Hide resolved
resources/views/seasons/show.blade.php Outdated Show resolved Hide resolved
database/migrations/2022_12_16_151601_create_season_rooms_table.php Outdated Show resolved Hide resolved
resources/lang/en/rankings.php Outdated Show resolved Hide resolved
nanaya
nanaya requested changes Feb 3, 2023
View reviewed changes
app/Http/Controllers/SeasonsController.php Outdated Show resolved Hide resolved
app/Models/Season.php Outdated Show resolved Hide resolved
@nanaya
Copy link
Collaborator

nanaya commented Feb 3, 2023

oh and being able to link to some url would probably be useful

@venix12
Copy link
Member Author

venix12 commented Feb 3, 2023

Tried to do some barebones url implementation, guess that could work for now?

@nanaya
Copy link
Collaborator

nanaya commented Feb 3, 2023

yeah probably fine for now

nanaya
nanaya requested changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, I forgot about list of internal urls in resources/js/utils/url.ts. /seasons needs to be added there as well

nanaya
nanaya previously approved these changes Feb 3, 2023
View reviewed changes
@nanaya nanaya enabled auto-merge February 3, 2023 13:42
auto-merge was automatically disabled February 3, 2023 13:44

Head branch was pushed to by a user without write access

@venix12
Copy link
Member Author

venix12 commented Feb 3, 2023

thought you'd tell me to redate migrations before merge 👀

@nanaya nanaya enabled auto-merge February 3, 2023 14:12
@nanaya nanaya merged commit 58a3c07 into ppy:master Feb 3, 2023
@venix12 venix12 mentioned this pull request Jan 2, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venix12 @nanaya