Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(cross-validation reporter): Remove timing_normalized plot #1055

Merged
merged 1 commit into from
Jan 8, 2025
Merged

revert(cross-validation reporter): Remove timing_normalized plot #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/getting_started/plot_quick_start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@
# %%
reporter.plots.scores

# %%
reporter.plots.timing_normalized

# %%
# Finally, from your shell (in the same directory), start the UI:
#
Expand Down
1 change: 0 additions & 1 deletion skore/src/skore/item/cross_validation_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@ def factory(cls, reporter: CrossValidationReporter) -> CrossValidationItem:
humanized_plot_names = {
"scores": "Scores",
"timing": "Timings",
"timing_normalized": "Normalized timings",
}
plots_bytes = {
humanized_plot_names[plot_name]: (
Expand Down
3 changes: 0 additions & 3 deletions skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
_strip_cv_results_scores,
)
from .plots.compare_scores_plot import plot_cross_validation_compare_scores
from .plots.timing_normalized_plot import plot_cross_validation_timing_normalized
from .plots.timing_plot import plot_cross_validation_timing


Expand All @@ -26,7 +25,6 @@ class CrossValidationPlots:

scores: plotly.graph_objects.Figure
timing: plotly.graph_objects.Figure
timing_normalized: plotly.graph_objects.Figure


class CrossValidationReporter:
Expand Down Expand Up @@ -189,5 +187,4 @@ def plots(self) -> CrossValidationPlots:
return CrossValidationPlots(
scores=plot_cross_validation_compare_scores(self._cv_results),
timing=plot_cross_validation_timing(self._cv_results),
timing_normalized=plot_cross_validation_timing_normalized(self._cv_results),
)
133 changes: 0 additions & 133 deletions skore/src/skore/sklearn/cross_validation/plots/timing_normalized_plot.py
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions skore/tests/unit/item/test_cross_validation_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ class FakeCrossValidationReporter(CrossValidationReporter):
plots = CrossValidationPlots(
scores=plotly.graph_objects.Figure(),
timing=plotly.graph_objects.Figure(),
timing_normalized=plotly.graph_objects.Figure(),
)
cv = StratifiedKFold(n_splits=5)

Expand All @@ -59,7 +58,6 @@ class FakeCrossValidationReporterNoGetParams(CrossValidationReporter):
plots = CrossValidationPlots(
scores=plotly.graph_objects.Figure(),
timing=plotly.graph_objects.Figure(),
timing_normalized=plotly.graph_objects.Figure(),
)
cv = StratifiedKFold(n_splits=5)

Expand Down
Loading