Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(cross-validation reporter): Remove timing_normalized plot #1055

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

augustebaum
Copy link
Contributor

Closes #1043

@augustebaum augustebaum linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage

pytest coverage report
FileStmtsMissCoverMissing
src/skore
   __init__.py120100% 
   __main__.py811 80%
   exceptions.py30100% 
src/skore/cli
   __init__.py50100% 
   cli.py330100% 
   color_format.py4332 90%
   launch_dashboard.py26150 39%
   quickstart_command.py140100% 
src/skore/item
   __init__.py210100% 
   cross_validation_item.py136113 92%
   item.py41130 68%
   item_repository.py4221 93%
   media_item.py7041 94%
   numpy_array_item.py2511 93%
   pandas_dataframe_item.py3411 95%
   pandas_series_item.py3411 95%
   polars_dataframe_item.py3211 94%
   polars_series_item.py2711 94%
   primitive_item.py2721 92%
   sklearn_base_estimator_item.py3311 95%
   skrub_table_report_item.py1011 86%
src/skore/persistence
   __init__.py00100% 
   abstract_storage.py2210 95%
   disk_cache_storage.py3311 95%
   in_memory_storage.py200100% 
src/skore/project
   __init__.py30100% 
   create.py5280 88%
   load.py2330 89%
   open.py140100% 
   project.py6444 91%
src/skore/sklearn
   __init__.py30100% 
   find_ml_task.py3532 89%
   types.py20100% 
src/skore/sklearn/cross_validation
   __init__.py20100% 
   cross_validation_helpers.py4241 89%
   cross_validation_reporter.py3511 95%
src/skore/sklearn/cross_validation/plots
   __init__.py00100% 
   compare_scores_plot.py2912 92%
   timing_plot.py2911 94%
src/skore/sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py3421 94%
src/skore/sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py1732 78%
   high_class_imbalance_warning.py1821 88%
   random_state_unset_warning.py1111 87%
   shuffle_true_warning.py901 91%
   stratify_is_set_warning.py1111 87%
   time_based_column_warning.py2212 89%
   train_test_split_warning.py510 80%
src/skore/ui
   __init__.py00100% 
   app.py2552 71%
   dependencies.py710 86%
   project_routes.py500100% 
src/skore/utils
   __init__.py00100% 
   _logger.py2140 84%
   _show_versions.py310100% 
src/skore/view
   __init__.py00100% 
   view.py50100% 
   view_repository.py1621 83%
TOTAL137410891% 

Tests Skipped Failures Errors Time
225 0 💤 0 ❌ 0 🔥 32.623s ⏱️

@glemaitre glemaitre self-requested a review January 8, 2025 10:03
glemaitre
glemaitre previously approved these changes Jan 8, 2025
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@glemaitre
Copy link
Member

You will need to amend the example: plot_quick_start.py where the item is used.

@glemaitre
Copy link
Member

I would also argue that the enum of the PR should "revert":

revert(cross-validation reporter): Remove timing_normalized plot

It looks part of https://commitlint.js.org/reference/rules.html#type-enum

@augustebaum augustebaum changed the title feat(cross-validation reporter): Remove timing_normalized plot revert(cross-validation reporter): Remove timing_normalized plot Jan 8, 2025
@augustebaum augustebaum force-pushed the 1043-feat-remove-time-per-data-point branch 2 times, most recently from 6ca2a98 to 77f6034 Compare January 8, 2025 11:10
@augustebaum augustebaum force-pushed the 1043-feat-remove-time-per-data-point branch from 77f6034 to cbf30d2 Compare January 8, 2025 13:19
@thomass-dev thomass-dev merged commit 29d3689 into main Jan 8, 2025
19 checks passed
@thomass-dev thomass-dev deleted the 1043-feat-remove-time-per-data-point branch January 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: remove time per data point
4 participants