-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert(cross-validation reporter): Remove timing_normalized plot #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
You will need to amend the example: plot_quick_start.py where the item is used. |
I would also argue that the enum of the PR should "revert":
It looks part of https://commitlint.js.org/reference/rules.html#type-enum |
augustebaum
changed the title
feat(cross-validation reporter): Remove timing_normalized plot
revert(cross-validation reporter): Remove timing_normalized plot
Jan 8, 2025
augustebaum
force-pushed
the
1043-feat-remove-time-per-data-point
branch
2 times, most recently
from
January 8, 2025 11:10
6ca2a98
to
77f6034
Compare
augustebaum
force-pushed
the
1043-feat-remove-time-per-data-point
branch
from
January 8, 2025 13:19
77f6034
to
cbf30d2
Compare
glemaitre
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1043