Support signatures produced by Polkadot JS signRaw
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
force-pushed
the
shams-verify-sign-raw-js
branch
from
5a77def to
3ffaf76
Compare
noah-foltz
previously approved these changes
Jul 31, 2024
shamsasari
force-pushed
the
shams-verify-sign-raw-js
branch
from
3ffaf76 to
530bb12
Compare
This function wraps the raw bytes with `<Bytes>` and `</Bytes>` before signing it. The `verify()` functions for `SignedVoteRequest` and `SignedRemoveVoteRequest` will try to verify with and without this wrapping to support both cases.
shamsasari
force-pushed
the
shams-verify-sign-raw-js
branch
from
530bb12 to
457dac8
Compare
noah-foltz
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signRawsilently wraps the raw bytes with<Bytes>and</Bytes>before signing it. Theverify()functions forSignedVoteRequestandSignedRemoveVoteRequestwill try to verify with and without this wrapping to support both cases.The REST API has also been updated to be support hex strings beginning with
0x.