Tag updates #2817
Merged
Tag updates #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here on a new line' Some users mistakenly put the `py` on a different line than the backticks, or put the code on the same line as the `py`. This is intended to subtly prompt readers not to do this.
The previous version began with "Iterating over range-len is a common approach ...", which sounds like an endorsement. Also removed "is guaranteed to produce elements in the same order", as I don't think anyone is actually confused about that. (I wrote the previous version--this is a criticism of my own writing.)
Xithrius
reviewed
Nov 23, 2023
| title: "Comparisons to `True` and `False`" | ||
| --- | ||
| It's tempting to think that if statements always need a comparison operator like `==` or `!=`, but this isn't true. | ||
| If you're just checking if a value is truthy or falsey, you don't need `== True` or `== False`. |
There was a problem hiding this comment.
truthy or falsey
Should we expand on what these mean?
There was a problem hiding this comment.
I lean towards no. It would make the scope of the tag a lot bigger and is not necessarily relevant to the reader. As is, newbies can make an assumption about what they mean and still understand the rest or they can ask what they mean. Either are good outcomes.
camcaswell
reviewed
Nov 24, 2023
| title: "Comparisons to `True` and `False`" | ||
| --- | ||
| It's tempting to think that if statements always need a comparison operator like `==` or `!=`, but this isn't true. | ||
| If you're just checking if a value is truthy or falsey, you don't need `== True` or `== False`. |
There was a problem hiding this comment.
I lean towards no. It would make the scope of the tag a lot bigger and is not necessarily relevant to the reader. As is, newbies can make an assumption about what they mean and still understand the rest or they can ask what they mean. Either are good outcomes.
wookie184
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates two tags and introduces a new one about comparisons to True and False.
Regarding the new tag, I'm open to suggestions (and destructive criticism) about using vertical space more sparingly in the code section. I don't like having
my_func(user_input)four times, but I'm worried that having...on the same line as the if statements will be confusing for beginners.