-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag updates #2817
Merged
Merged
Tag updates #2817
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4d1ba10
Capitalize "Discord" in header; Change print statement to 'Code goes …
swfarnsworth 96038fd
Rewriting of non-code sections.
swfarnsworth 36f1aa2
New tag to explain why `== True` et al are wrong.
swfarnsworth 0ff5fad
Revert 'Code goes here on a new line' to 'Hello world!'
swfarnsworth 0ccd4fb
Merge branch 'main' into swfarnsworth/tag-updates
wookie184 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
--- | ||
embed: | ||
title: "Comparisons to `True` and `False`" | ||
--- | ||
It's tempting to think that if statements always need a comparison operator like `==` or `!=`, but this isn't true. | ||
If you're just checking if a value is truthy or falsey, you don't need `== True` or `== False`. | ||
```py | ||
# instead of this... | ||
if user_input.startswith('y') == True: | ||
my_func(user_input) | ||
|
||
# ...write this | ||
if user_input.startswith('y'): | ||
my_func(user_input) | ||
|
||
# for false conditions, instead of this... | ||
if user_input.startswith('y') == False: | ||
my_func(user_input) | ||
|
||
# ...just use `not` | ||
if not user_input.startswith('y'): | ||
my_func(user_input) | ||
``` | ||
This also applies to expressions that use `is True` or `is False`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we expand on what these mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lean towards no. It would make the scope of the tag a lot bigger and is not necessarily relevant to the reader. As is, newbies can make an assumption about what they mean and still understand the rest or they can ask what they mean. Either are good outcomes.