Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support adaptive avg pool 2d and 3d dynamo converters #2632

Merged
merged 5 commits into from
Apr 12, 2024
Merged

feat: support adaptive avg pool 2d and 3d dynamo converters #2632

merged 5 commits into from
Apr 12, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Support adaptive_avg_pool2d and adaptive_avg_pool3d.

Fixes #2611 #2612

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Feb 1, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 1, 2024
@github-actions github-actions bot requested a review from apbose February 1, 2024 01:59
@zewenli98 zewenli98 removed component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 1, 2024
@narendasan narendasan linked an issue Feb 6, 2024 that may be closed by this pull request
aten.adaptive_avg_pool3d #2612
Closed
@zewenli98 zewenli98 mentioned this pull request Feb 8, 2024
Merged
7 tasks
@zewenli98 zewenli98 force-pushed the adaptive_avg_poolNd_dynamo_converter branch from 98524e0 to 8c41f14 Compare February 9, 2024 00:56
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 9, 2024
@zewenli98 zewenli98 requested a review from narendasan February 17, 2024 00:22
@zewenli98 zewenli98 force-pushed the adaptive_avg_poolNd_dynamo_converter branch from 65bbf45 to 2100974 Compare February 23, 2024 01:55
narendasan
narendasan approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@zewenli98 zewenli98 force-pushed the adaptive_avg_poolNd_dynamo_converter branch from 2100974 to e2e0aa5 Compare March 21, 2024 23:58
@zewenli98 zewenli98 requested a review from narendasan April 8, 2024 20:40
gs-olive
gs-olive reviewed Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - added a few small suggestions

py/torch_tensorrt/dynamo/conversion/impl/pool.py Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/pool.py Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/pool.py Show resolved Hide resolved
@zewenli98 zewenli98 requested a review from gs-olive April 10, 2024 17:10
gs-olive
gs-olive approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two small comments - looks good to me pending CI for the test cases and those fixes.

tests/py/dynamo/conversion/test_adaptive_avgpool_aten.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Show resolved Hide resolved
narendasan
narendasan approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit e232ffa into pytorch:main Apr 12, 2024
16 of 21 checks passed
peri044 pushed a commit that referenced this pull request Apr 19, 2024
@zewenli98 @peri044
feat: support adaptive avg pool 2d and 3d dynamo converters (#2632)
264905d
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @laikhtewari
feat: support adaptive avg pool 2d and 3d dynamo converters (#2632)
1e56b61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@gs-olive gs-olive gs-olive approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.adaptive_avg_pool3d aten.adaptive_avg_pool2d
4 participants
@zewenli98 @narendasan @gs-olive @facebook-github-bot