New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw. #7816

Merged

facebook-github-bot merged 6 commits into gh/trivedivivek/48/base from gh/trivedivivek/48/head

Jan 27, 2025

Contributor

trivedivivek commented Jan 21, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

This diff splits the TILE_SIZE variable in the conv2d_pw GLSL code into TILE_SIZE_X and TILE_SIZE_Y. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: D68400783


          [ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw.

975e5d5

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

[ghstack-poisoned]

pytorch-bot bot commented Jan 21, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7816

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c8e403f with merge base e78ed83 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
backends/xnnpack/test/ops/test_add.py::TestAdd::test_qs8_add3
pull / unittest / macos / macos-job (gh) (trunk failure)
backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jan 21, 2025

This pull request was exported from Phabricator. Differential Revision: D68400783

facebook-github-bot added the fb-exported label

This was referenced Jan 21, 2025

[ET-VK] Minor improvement to q_linear op shader. #7728

Merged

[ET-VK] Using push constants for conv2d pw. #7814

Merged

[ET-VK] Minor improvements to conv2d pw and dw bounds check. #7815

Merged

[ET-VK] Using shared memory offsetting in conv2d pw and saving ivec3 pos instead of ivec2 to improve performance. #7817

Merged

[ET-VK] Using shared memory to save position in conv2d dw output op. #7818

Open


          Update on "[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y…

9d189c0

… in conv2d pw."

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 22, 2025

This pull request was exported from Phabricator. Differential Revision: D68400783


          Update on "[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y…

67e4d95

… in conv2d pw."

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 24, 2025

This pull request was exported from Phabricator. Differential Revision: D68400783

trivedivivek mentioned this pull request

[ET-VK] Using shared memory to save position in conv2d dw output op. #7923

Merged

trivedivivek added the topic: not user facing label

This was referenced Jan 24, 2025

[ET-VK] Using push constants for conv2d dw. #7928

Merged

[ET-VK] Using TmpTensor for width packed versions of q_linear op shader to reduce memory usage. #7929

Merged


          Update on "[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y…

5b35a2b

… in conv2d pw."

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 24, 2025

This pull request was exported from Phabricator. Differential Revision: D68400783

nathanaelsee approved these changes

View reviewed changes


          Update on "[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y…

e5ce0b9

… in conv2d pw."

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 27, 2025

This pull request was exported from Phabricator. Differential Revision: D68400783


          Update on "[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y…

c8e403f

… in conv2d pw."

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 27, 2025

This pull request was exported from Phabricator. Differential Revision: D68400783

facebook-github-bot merged commit b818123 into gh/trivedivivek/48/base

44 of 47 checks passed

facebook-github-bot deleted the gh/trivedivivek/48/head branch

January 27, 2025 20:30

facebook-github-bot temporarily deployed to cherry-pick-bot

January 27, 2025 20:30

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw. #7972

Merged

kirklandsign pushed a commit that referenced this pull request


          [ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw.

6db3f87

Pull Request resolved: #7816

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.
ghstack-source-id: 263238734
@exported-using-ghexport

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

---------

Co-authored-by: Vivek Trivedi <[email protected]>

YIWENX14 pushed a commit that referenced this pull request


          [ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw.

bb75db0

Pull Request resolved: #7816

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.
ghstack-source-id: 263238734
@exported-using-ghexport

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

---------

Co-authored-by: Vivek Trivedi <[email protected]>

zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request


          [ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw.

ab0b534

Pull Request resolved: pytorch#7816

This diff splits the `TILE_SIZE` variable in the `conv2d_pw` GLSL code into `TILE_SIZE_X` and `TILE_SIZE_Y`. This change is made so tile size in different dimensions can be tuned separately.
ghstack-source-id: 263238734
@exported-using-ghexport

Differential Revision: [D68400783](https://our.internmc.facebook.com/intern/diff/D68400783/)

---------

Co-authored-by: Vivek Trivedi <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing