[ET-VK] Using shared memory offsetting in conv2d pw and saving ivec3 pos instead of ivec2 to improve performance. #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pos instead of ivec2 to improve performance. This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7817
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b89ced3 with merge base e78ed83 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
This was referenced Jan 21, 2025
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
This was referenced Jan 24, 2025
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
jorgep31415
approved these changes
Jan 24, 2025
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
…ving ivec3 pos instead of ivec2 to improve performance." This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400786 |
facebook-github-bot
merged commit 16d44b6
into
gh/trivedivivek/49/base
45 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Jan 27, 2025
…pos instead of ivec2 to improve performance. Pull Request resolved: #7817 This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. ghstack-source-id: 263238733 @exported-using-ghexport Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/)
kirklandsign
pushed a commit
that referenced
this pull request
Jan 27, 2025
…pos instead of ivec2 to improve performance. Pull Request resolved: #7817 This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. ghstack-source-id: 263238733 @exported-using-ghexport Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) Co-authored-by: Vivek Trivedi <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
…pos instead of ivec2 to improve performance. Pull Request resolved: #7817 This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. ghstack-source-id: 263238733 @exported-using-ghexport Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) Co-authored-by: Vivek Trivedi <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
…pos instead of ivec2 to improve performance. Pull Request resolved: pytorch#7817 This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2. ghstack-source-id: 263238733 @exported-using-ghexport Differential Revision: [D68400786](https://our.internmc.facebook.com/intern/diff/D68400786/) Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff changes conv2d pw op shader to offset shared memory based on thread local index to improve performance. Change also saves pos as ivec3 pos instead of ivec2.
Differential Revision: D68400786